Round the subpixel accumulation used for composited scrolling content

third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
index 2d2167ead07fe3179ddd06a2d1ff2c1169700c52..703c09dd1b3d1a86de11a49d82b1266ca8a88c90 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
@@ -3046,10 +3046,18 @@ void CompositedLayerMapping::DoPaintTask(
 
   if (paint_info.paint_layer->GetCompositingState() !=
       kPaintsIntoGroupedBacking) {
+    LayoutSize sub_pixel_accumulation =
+        paint_info.paint_layer->SubpixelAccumulation();
+    if (paint_layer_flags & kPaintLayerPaintingCompositingScrollingPhase) {
+      // The composited scrolling contents layer position rounds the subpixel
+      // accumulation.
+      sub_pixel_accumulation =

[chrishtr, 2017/05/05 01:14:09]

This will round off the subpixel accumulation for the entire composited
scrolling layer, right? Why is that correct? Now I'm no longer sure
I understand why the background is not being painted to the edge of the
composited layer. Layers are positioned at snapped locations, but they
have subpixel offsets to record the extra offset.

[flackr, 2017/05/05 17:02:19]

The composited scrolling content geometry size does not take into account the
scroller's location, but the subpixel accumulation and painting code does. This
leads to the 1px gap. I'm now thinking the better change is to compute the
composited scrolling layer geometry with the correct size based on the layout
box location and then we could respect the subpixel accumulation. I'll start
doing this but let me know if you have any objections.

+          LayoutSize(RoundedIntSize(sub_pixel_accumulation));
+    }
     // FIXME: GraphicsLayers need a way to split for multicol.
     PaintLayerPaintingInfo painting_info(
         paint_info.paint_layer, LayoutRect(dirty_rect), kGlobalPaintNormalPhase,
-        paint_info.paint_layer->SubpixelAccumulation());
+        sub_pixel_accumulation);
     PaintLayerPainter(*paint_info.paint_layer)
         .PaintLayerContents(context, painting_info, paint_layer_flags);