Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 2727223002: Round the subpixel accumulation used for composited scrolling content (Closed)
Patch Set: Merge and remove subpixel adjustment for transformed fragments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-content-fractional-offset-expected.html ('k') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp » ('j') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Simon Hausmann <hausmann@kde.org> 5 * 2000 Simon Hausmann <hausmann@kde.org>
6 * 2000 Stefan Schimanski <1Stein@gmx.de> 6 * 2000 Stefan Schimanski <1Stein@gmx.de>
7 * 2001 George Staikos <staikos@kde.org> 7 * 2001 George Staikos <staikos@kde.org>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
9 * rights reserved. 9 * rights reserved.
10 * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com> 10 * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com>
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 PaintLayer* layer = dragged_layout_object->EnclosingLayer(); 204 PaintLayer* layer = dragged_layout_object->EnclosingLayer();
205 if (!layer->StackingNode()->IsStackingContext()) 205 if (!layer->StackingNode()->IsStackingContext())
206 layer = layer->StackingNode()->AncestorStackingContextNode()->Layer(); 206 layer = layer->StackingNode()->AncestorStackingContextNode()->Layer();
207 IntRect absolute_bounding_box = 207 IntRect absolute_bounding_box =
208 dragged_layout_object->AbsoluteBoundingBoxRectIncludingDescendants(); 208 dragged_layout_object->AbsoluteBoundingBoxRectIncludingDescendants();
209 FloatRect bounding_box = 209 FloatRect bounding_box =
210 layer->GetLayoutObject() 210 layer->GetLayoutObject()
211 .AbsoluteToLocalQuad(FloatQuad(absolute_bounding_box), 211 .AbsoluteToLocalQuad(FloatQuad(absolute_bounding_box),
212 kUseTransforms) 212 kUseTransforms)
213 .BoundingBox(); 213 .BoundingBox();
214 DCHECK(layer->GetCompositingState() != kPaintsIntoOwnBacking ||
215 layer->SubpixelAccumulation().IsZero());
214 PaintLayerPaintingInfo painting_info(layer, LayoutRect(bounding_box), 216 PaintLayerPaintingInfo painting_info(layer, LayoutRect(bounding_box),
215 kGlobalPaintFlattenCompositingLayers, 217 kGlobalPaintFlattenCompositingLayers,
216 LayoutSize()); 218 LayoutSize());
217 PaintLayerFlags flags = kPaintLayerHaveTransparency | 219 PaintLayerFlags flags = kPaintLayerHaveTransparency |
218 kPaintLayerAppliedTransform | 220 kPaintLayerAppliedTransform |
219 kPaintLayerUncachedClipRects; 221 kPaintLayerUncachedClipRects;
220 PaintRecordBuilder builder(DeviceSpaceBounds(bounding_box, *local_frame_)); 222 PaintRecordBuilder builder(DeviceSpaceBounds(bounding_box, *local_frame_));
221 PaintLayerPainter(*layer).Paint(builder.Context(), painting_info, flags); 223 PaintLayerPainter(*layer).Paint(builder.Context(), painting_info, flags);
222 PropertyTreeState border_box_properties = PropertyTreeState::Root(); 224 PropertyTreeState border_box_properties = PropertyTreeState::Root();
223 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) { 225 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
(...skipping 739 matching lines...) Expand 10 before | Expand all | Expand 10 after
963 if (Client() && 965 if (Client() &&
964 Client()->ShouldUseClientLoFiForRequest(params.GetResourceRequest())) { 966 Client()->ShouldUseClientLoFiForRequest(params.GetResourceRequest())) {
965 params.MutableResourceRequest().SetPreviewsState( 967 params.MutableResourceRequest().SetPreviewsState(
966 params.GetResourceRequest().GetPreviewsState() | 968 params.GetResourceRequest().GetPreviewsState() |
967 WebURLRequest::kClientLoFiOn); 969 WebURLRequest::kClientLoFiOn);
968 params.SetAllowImagePlaceholder(); 970 params.SetAllowImagePlaceholder();
969 } 971 }
970 } 972 }
971 973
972 } // namespace blink 974 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-content-fractional-offset-expected.html ('k') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp » ('j') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698