third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp - Issue 2727133002: Remove ColorBehavior argument to Image::imageForCurrentFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 2727133002: Remove ColorBehavior argument to Image::imageForCurrentFrame (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/ImageData.cpp ('K') | « third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp ('k') | third_party/WebKit/Source/platform/DragImage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

index 74e1cf0ed87d6831c0863639b0d398373ccfa7b3..244801057802e3e1ac4674d77bbecfda2632aeec 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

@@ -5426,10 +5426,7 @@ void WebGLRenderingContextBase::texImageHelperImageBitmap(

}

return;

}

- // TODO(ccameron): WebGL should produce sRGB images.

- // https://crbug.com/672299

- sk_sp<SkImage> skImage = bitmap->bitmapImage()->imageForCurrentFrame(

- ColorBehavior::transformToGlobalTarget());

+ sk_sp<SkImage> skImage = bitmap->bitmapImage()->imageForCurrentFrame();

SkPixmap pixmap;

uint8_t* pixelDataPtr = nullptr;

RefPtr<Uint8Array> pixelData;