[Media Router] Custom Controls 1 - Add MediaStatus, MediaRouteController, and mojo interfaces

extensions/renderer/dispatcher.cc

Index: extensions/renderer/dispatcher.cc
diff --git a/extensions/renderer/dispatcher.cc b/extensions/renderer/dispatcher.cc
index 4dcf0389e2b7fd0f8d7a1ccc456b58670f6267d1..126c62447ceb7229f5987595daa115b5b6496566 100644
--- a/extensions/renderer/dispatcher.cc
+++ b/extensions/renderer/dispatcher.cc
@@ -139,7 +139,7 @@ static const char kOnSuspendCanceledEvent[] = "runtime.onSuspendCanceled";
 
 void CrashOnException(const v8::TryCatch& trycatch) {
   NOTREACHED();
-};
+}
 
 // Calls a method |method_name| in a module |module_name| belonging to the
 // module system from |context|. Intended as a callback target from
@@ -751,8 +751,12 @@ std::vector<std::pair<const char*, int>> Dispatcher::GetJsResources() {
     {"platformApp", IDR_PLATFORM_APP_JS},
 
 #if defined(ENABLE_MEDIA_ROUTER)
+    {"chrome/browser/media/router/mojo/media_controller.mojom",

[Nico, 2017/03/23 18:36:49]

This adds many more dependencies from extensions/ to chrome/. Since chrome
already depends, that's an (implicit) dependency cycle, and this does not lgtm.
Please revert this and come up with a way to handle this without this dependency
cycle.

[imcheng, 2017/03/23 19:03:16]

These dependencies need to exist for the Media Router extension to work
properly. If the problem is simply where these mojom files are located in, then
we can move them somewhere else to break the cycle. In
https://codereview.chromium.org/1162243002/ I suggested
//components/media_router., but I think //media/router (or //media/mojo/router)
should work too. Please let me know if that's not the case.

I don't think this warrants a revert. The implicit cycle has existed for quite
some time now and this patch doesn't break anything. I do think it's a good idea
to remove this cycle as soon as we figure out where to relocate the mojom files.

+     IDR_MEDIA_CONTROLLER_MOJOM_JS},
     {"chrome/browser/media/router/mojo/media_router.mojom",
      IDR_MEDIA_ROUTER_MOJOM_JS},
+    {"chrome/browser/media/router/mojo/media_status.mojom",
+     IDR_MEDIA_STATUS_MOJOM_JS},
     {"media_router_bindings", IDR_MEDIA_ROUTER_BINDINGS_JS},
     {"mojo/common/time.mojom", IDR_MOJO_TIME_MOJOM_JS},
     {"net/interfaces/ip_address.mojom", IDR_MOJO_IP_ADDRESS_MOJOM_JS},