[Media Router] Custom Controls 1 - Add MediaStatus, MediaRouteController, and mojo interfaces

extensions/renderer/dispatcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/dispatcher.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <utility>
@@ skipping 121 matching lines @@
 
 namespace {
 
 static const int64_t kInitialExtensionIdleHandlerDelayMs = 5 * 1000;
 static const int64_t kMaxExtensionIdleHandlerDelayMs = 5 * 60 * 1000;
 static const char kOnSuspendEvent[] = "runtime.onSuspend";
 static const char kOnSuspendCanceledEvent[] = "runtime.onSuspendCanceled";
 
 void CrashOnException(const v8::TryCatch& trycatch) {
   NOTREACHED();
-};
+}
 
 // Calls a method |method_name| in a module |module_name| belonging to the
 // module system from |context|. Intended as a callback target from
 // ScriptContextSet::ForEach.
 void CallModuleMethod(const std::string& module_name,
                       const std::string& method_name,
                       const base::ListValue* args,
                       ScriptContext* context) {
   v8::HandleScope handle_scope(context->isolate());
   v8::Context::Scope context_scope(context->v8_context());
@@ skipping 582 matching lines @@
     {"webViewRequest", IDR_WEB_VIEW_REQUEST_CUSTOM_BINDINGS_JS},
     {"binding", IDR_BINDING_JS},
 
     // Custom types sources.
     {"StorageArea", IDR_STORAGE_AREA_JS},
 
     // Platform app sources that are not API-specific..
     {"platformApp", IDR_PLATFORM_APP_JS},
 
 #if defined(ENABLE_MEDIA_ROUTER)
+    {"chrome/browser/media/router/mojo/media_controller.mojom",

[Devlin, 2017/03/06 22:51:05]

Where are these used?  I can't find them being required anywhere.

[takumif, 2017/03/08 04:24:03]

media_router.mojom includes these two files, so the Media Router component
extension throws an error if they aren't included here.

[Devlin, 2017/03/08 19:33:23]

Why?  These resources are added to the Dispatcher's source map, which is only
used when require()'ing js resources.  Unless we somewhere map a mojom's #import
to require() (which I hope we don't), I don't see the correlation?

+     IDR_MEDIA_CONTROLLER_MOJOM_JS},
     {"chrome/browser/media/router/mojo/media_router.mojom",
      IDR_MEDIA_ROUTER_MOJOM_JS},
+    {"chrome/browser/media/router/mojo/media_status.mojom",
+     IDR_MEDIA_STATUS_MOJOM_JS},
     {"mojo/common/time.mojom", IDR_MOJO_TIME_MOJOM_JS},
     {"url/mojo/origin.mojom", IDR_ORIGIN_MOJOM_JS},
     {"media_router_bindings", IDR_MEDIA_ROUTER_BINDINGS_JS},
 #endif  // defined(ENABLE_MEDIA_ROUTER)
   };
 
   if (base::FeatureList::IsEnabled(::features::kGuestViewCrossProcessFrames)) {
     resources.emplace_back("guestViewIframe", IDR_GUEST_VIEW_IFRAME_JS);
     resources.emplace_back("guestViewIframeContainer",
                            IDR_GUEST_VIEW_IFRAME_CONTAINER_JS);
@@ skipping 651 matching lines @@
   // The "guestViewDeny" module must always be loaded last. It registers
   // error-providing custom elements for the GuestView types that are not
   // available, and thus all of those types must have been checked and loaded
   // (or not loaded) beforehand.
   if (context_type == Feature::BLESSED_EXTENSION_CONTEXT) {
     module_system->Require("guestViewDeny");
   }
 }
 
 }  // namespace extensions