[Media Router] Custom Controls 1 - Add MediaStatus, MediaRouteController, and mojo interfaces

chrome/browser/media/router/mojo/media_route_controller.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/media/router/mojo/media_route_controller.h"
+
+#include <utility>
+
+#include "chrome/browser/media/router/media_route_status_observer.h"
+#include "chrome/browser/media/router/media_router.h"
+#include "chrome/browser/media/router/media_status.h"
+#include "chrome/browser/media/router/mojo/media_router.mojom.h"
+#include "mojo/public/cpp/bindings/interface_request.h"
+
+namespace media_router {
+
+MediaRouteController::MediaRouteController(MediaRoute::Id route_id,
+                                           mojom::MediaRouteProvider* provider,
+                                           base::Closure destroyer_callback)
+    : destroyer_callback_(destroyer_callback),
+      provider_(provider),
+      route_id_(route_id) {
+  provider_->CreateMediaRouteController(

[imcheng, 2017/03/06 23:11:41]

A couple of questions.

1) Can the initialization of the mojo controller and mojo observer be one step?
2) Can the calls to MediaRouteProvider to initialize the controller be moved to
MediaRouterMojoImpl? 

[takumif, 2017/03/08 04:24:02]

Yes, both are possible. Doing so.

+      route_id_, mojo::MakeRequest<mojom::MediaController>(&media_controller_),
+      base::Bind(&MediaRouteController::OnControllerSet,
+                 base::Unretained(this)));
+}
+MediaRouteController::~MediaRouteController() {}
+
+void MediaRouteController::OnControllerSet(bool success) {
+  if (success) {
+    mojom::MediaStatusObserverPtr observer;
+    binding_ = base::MakeUnique<mojo::Binding<mojom::MediaStatusObserver>>(
+        this, mojo::MakeRequest<mojom::MediaStatusObserver>(&observer));
+    binding_->set_connection_error_handler(destroyer_callback_);
+    provider_->SetMediaRouteStatusObserver(route_id_, std::move(observer));
+  } else {
+    destroyer_callback_.Run();
+    // |this| gets destroyed here!
+  }
+}
+
+void MediaRouteController::Play() {
+  media_controller_->Play();
+}
+
+void MediaRouteController::Pause() {
+  media_controller_->Pause();
+}
+
+void MediaRouteController::Seek(uint32_t time) {
+  media_controller_->Seek(time);
+}
+
+void MediaRouteController::SetMute(bool mute) {
+  media_controller_->SetMute(mute);
+}
+
+void MediaRouteController::SetVolume(float volume) {
+  media_controller_->SetVolume(volume);
+}
+
+void MediaRouteController::AddObserver(MediaRouteStatusObserver* observer) {
+  observers_.insert(observer);
+}
+
+void MediaRouteController::RemoveObserver(MediaRouteStatusObserver* observer) {
+  observers_.erase(observer);
+  if (observers_.empty()) {
+    destroyer_callback_.Run();
+    // |this| gets destroyed here!
+  }
+}
+
+void MediaRouteController::OnMediaStatusUpdated(const MediaStatus& status) {
+  for (MediaRouteStatusObserver* observer : observers_)
+    observer->OnMediaRouteStatusUpdated(status);
+}
+
+}  // namespace media_router