Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: src/codegen-ia32.cc

Issue 27271: A cosmetic change in CodeGenerator::VisitAssignment. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/codegen-ia32.cc
===================================================================
--- src/codegen-ia32.cc (revision 1380)
+++ src/codegen-ia32.cc (working copy)
@@ -2763,8 +2763,8 @@
target.type() == Reference::KEYED);
// Change to slow case in the beginning of an initialization block
// to avoid the quadratic behavior of repeatedly adding fast properties.
- int stack_position = (target.type() == Reference::NAMED) ? 0 : 1;
- frame_->Push(Operand(esp, stack_position * kPointerSize));
+ int index = (target.type() == Reference::NAMED) ? 0 : 1;
+ frame_->Push(frame_->Element(index));
__ CallRuntime(Runtime::kToSlowProperties, 1);
}
if (node->op() == Token::ASSIGN ||
@@ -2802,8 +2802,8 @@
ASSERT(target.type() == Reference::NAMED ||
target.type() == Reference::KEYED);
// End of initialization block. Revert to fast case.
- int stack_position = (target.type() == Reference::NAMED) ? 1 : 2;
- frame_->Push(Operand(esp, stack_position * kPointerSize));
+ int index = (target.type() == Reference::NAMED) ? 1 : 2;
+ frame_->Push(frame_->Element(index));
__ CallRuntime(Runtime::kToFastProperties, 1);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698