Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Issue 2727093002: Account for perspective and preserve-3d in mapToVisualRectInAncestorSpace (Closed)
Patch Set: none Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
index 489ab1b6c0c39999af10afdc458f627c4acf9fa0..c27228946e7a0a51a5fc71821ca86fa1e9601660 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
@@ -2063,9 +2063,9 @@ bool LayoutTableSection::isRepeatingHeaderGroup() const {
return true;
}
-bool LayoutTableSection::mapToVisualRectInAncestorSpace(
+bool LayoutTableSection::mapToVisualRectInAncestorSpaceInternal(
const LayoutBoxModelObject* ancestor,
- LayoutRect& rect,
+ TransformState& transformState,
VisualRectFlags flags) const {
if (ancestor == this)
return true;
@@ -2075,10 +2075,14 @@ bool LayoutTableSection::mapToVisualRectInAncestorSpace(
// the header in all columns.
// Note that this is in flow thread coordinates, not visual coordinates. The
// enclosing LayoutFlowThread will convert to visual coordinates.
- if (table()->header() == this && isRepeatingHeaderGroup())
+ if (table()->header() == this && isRepeatingHeaderGroup()) {
+ transformState.flatten();
+ FloatRect rect = transformState.lastPlanarQuad().boundingBox();
rect.setHeight(table()->logicalHeight());
- return LayoutTableBoxComponent::mapToVisualRectInAncestorSpace(ancestor, rect,
- flags);
+ transformState.setQuad(FloatQuad(rect));
+ }
+ return LayoutTableBoxComponent::mapToVisualRectInAncestorSpaceInternal(
+ ancestor, transformState, flags);
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableSection.h ('k') | third_party/WebKit/Source/core/layout/LayoutView.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698