Account for perspective and preserve-3d in mapToVisualRectInAncestorSpace

third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/paint/PaintInvalidator.h"
 
 #include "core/editing/FrameSelection.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/Settings.h"
@@ skipping 15 matching lines @@
     const LayoutBoxModelObject& ancestor,
     const Rect& rect) {
   if (object.isSVGChild()) {
     LayoutRect result;
     SVGLayoutSupport::mapToVisualRectInAncestorSpace(object, &ancestor,
                                                      FloatRect(rect), result);
     return result;
   }
 
   LayoutRect result(rect);
-  if (object.isLayoutView())
-    toLayoutView(object).mapToVisualRectInAncestorSpace(
-        &ancestor, result, InputIsInFrameCoordinates, DefaultVisualRectFlags);
-  else
-    object.mapToVisualRectInAncestorSpace(&ancestor, result);
+  if (object.isLayoutView()) {
+    TransformState transformState(TransformState::ApplyTransformDirection,
+                                  FloatQuad(FloatRect(rect)));
+    toLayoutView(object).mapToVisualRectInAncestorSpaceInternal(
+        &ancestor, transformState, InputIsInFrameCoordinates,
+        DefaultVisualRectFlags);
+    transformState.flatten();
+    return LayoutRect(transformState.lastPlanarQuad().boundingBox());

[Xianzhu, 2017/03/03 01:24:42]

Can you wrap the above code into LayoutView::mapToVisualRectInAncestorSpace()?

[chrishtr, 2017/03/03 02:45:11]

Done.

+  }
+
+  object.mapToVisualRectInAncestorSpace(&ancestor, result);
   return result;
 }
 
 // TODO(wangxianzhu): Combine this into
 // PaintInvalidator::mapLocalRectToBacking() when removing
 // PaintInvalidationState.
 // This function is templatized to avoid FloatRect<->LayoutRect conversions
 // which affect performance.
 template <typename Rect, typename Point>
 static LayoutRect mapLocalRectToPaintInvalidationBacking(
@@ skipping 416 matching lines @@
         PaintInvalidatorContext::ForcedSubtreeInvalidationRectUpdate;
 }
 
 void PaintInvalidator::processPendingDelayedPaintInvalidations() {
   for (auto target : m_pendingDelayedPaintInvalidations)
     target->getMutableForPainting().setShouldDoFullPaintInvalidation(
         PaintInvalidationDelayedFull);
 }
 
 }  // namespace blink