Add UKM API GetNewSourceID()

components/ukm/ukm_service_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ukm/ukm_service.h"
 
 #include <string>
 #include <utility>
 
 #include "base/hash.h"
@@ skipping 82 matching lines @@
 }
 
 TEST_F(UkmServiceTest, PersistAndPurge) {
   UkmService service(&prefs_, &client_);
   EXPECT_EQ(GetPersistedLogCount(), 0);
   service.Initialize();
   task_runner_->RunUntilIdle();
   service.EnableRecording();
   service.EnableReporting();
 
-  int32_t id = 1;
+  int32_t id = UkmService::GetNewSourceID();
   service.UpdateSourceURL(id, GURL("https://google.com/foobar"));
   // Should init, generate a log, and start an upload for source.
   task_runner_->RunPendingTasks();
   EXPECT_TRUE(client_.uploader()->is_uploading());
   // Flushes the generated log to disk and generates a new entry.
   {
     std::unique_ptr<UkmEntryBuilder> builder =
         service.GetEntryBuilder(id, "PageLoad");
     builder->AddMetric("FirstContentfulPaint", 300);
   }
   service.Flush();
   EXPECT_EQ(GetPersistedLogCount(), 2);
   service.Purge();
   EXPECT_EQ(GetPersistedLogCount(), 0);
 }
 
 TEST_F(UkmServiceTest, SourceSerialization) {
   UkmService service(&prefs_, &client_);
   EXPECT_EQ(GetPersistedLogCount(), 0);
   service.Initialize();
   task_runner_->RunUntilIdle();
   service.EnableRecording();
   service.EnableReporting();
 
-  int32_t id = 1;
+  int32_t id = UkmService::GetNewSourceID();
   service.UpdateSourceURL(id, GURL("https://google.com/foobar"));
 
   service.Flush();
   EXPECT_EQ(GetPersistedLogCount(), 1);
 
   Report proto_report = GetPersistedReport();
   EXPECT_EQ(1, proto_report.sources_size());
   const Source& proto_source = proto_report.sources(0);
 
   EXPECT_EQ(id, proto_source.id());
   EXPECT_EQ(GURL("https://google.com/foobar").spec(), proto_source.url());
 }
 
 TEST_F(UkmServiceTest, EntryBuilderAndSerialization) {
   UkmService service(&prefs_, &client_);
   EXPECT_EQ(0, GetPersistedLogCount());
   service.Initialize();
   task_runner_->RunUntilIdle();
   service.EnableRecording();
   service.EnableReporting();
 
-  int32_t id = 1;
+  int32_t id = UkmService::GetNewSourceID();
   service.UpdateSourceURL(id, GURL("https://google.com/foobar"));
   {
     std::unique_ptr<UkmEntryBuilder> foo_builder =
         service.GetEntryBuilder(id, "foo");
     foo_builder->AddMetric("foo_start", 0);
     foo_builder->AddMetric("foo_end", 10);
 
     std::unique_ptr<UkmEntryBuilder> bar_builder =
         service.GetEntryBuilder(id, "bar");
     bar_builder->AddMetric("bar_start", 5);
@@ skipping 42 matching lines @@
 }
 
 TEST_F(UkmServiceTest, AddEntryOnlyWithNonEmptyMetrics) {
   UkmService service(&prefs_, &client_);
   EXPECT_EQ(0, GetPersistedLogCount());
   service.Initialize();
   task_runner_->RunUntilIdle();
   service.EnableRecording();
   service.EnableReporting();
 
-  int32_t id = 1;
+  int32_t id = UkmService::GetNewSourceID();
   service.UpdateSourceURL(id, GURL("https://google.com/foobar"));
 
   {
     std::unique_ptr<UkmEntryBuilder> builder =
         service.GetEntryBuilder(id, "PageLoad");
   }
   service.Flush();
   EXPECT_EQ(1, GetPersistedLogCount());
   Report proto_report = GetPersistedReport();
   EXPECT_EQ(0, proto_report.entries_size());
@@ skipping 18 matching lines @@
 
   service.Initialize();
 
   // Providers have not supplied system profile information yet.
   EXPECT_FALSE(provider->provide_system_profile_metrics_called());
 
   task_runner_->RunUntilIdle();
   service.EnableRecording();
   service.EnableReporting();
 
-  int32_t id = 1;
+  int32_t id = UkmService::GetNewSourceID();
   service.UpdateSourceURL(id, GURL("https://google.com/foobar"));
   {
     std::unique_ptr<UkmEntryBuilder> builder =
         service.GetEntryBuilder(id, "PageLoad");
     builder->AddMetric("FirstContentfulPaint", 300);
   }
   service.Flush();
   EXPECT_EQ(GetPersistedLogCount(), 1);
 
   Report proto_report = GetPersistedReport();
@@ skipping 11 matching lines @@
   task_runner_->RunUntilIdle();
   service.EnableRecording();
   service.EnableReporting();
 
   EXPECT_TRUE(task_runner_->HasPendingTask());
   // Neither rotation or Flush should generate logs
   task_runner_->RunPendingTasks();
   service.Flush();
   EXPECT_EQ(GetPersistedLogCount(), 0);
 
-  int32_t id = 1;
+  int32_t id = UkmService::GetNewSourceID();
   service.UpdateSourceURL(id, GURL("https://google.com/foobar"));
   // Includes a Source, so will persist.
   service.Flush();
   EXPECT_EQ(GetPersistedLogCount(), 1);
 
   {
     std::unique_ptr<UkmEntryBuilder> builder =
         service.GetEntryBuilder(id, "PageLoad");
     builder->AddMetric("FirstPaint", 300);
   }
   // Includes an Entry, so will persist.
   service.Flush();
   EXPECT_EQ(GetPersistedLogCount(), 2);
 
   service.UpdateSourceURL(id, GURL("https://google.com/foobar"));
   {
     std::unique_ptr<UkmEntryBuilder> builder =
         service.GetEntryBuilder(id, "PageLoad");
     builder->AddMetric("FirstContentfulPaint", 300);
   }
   // Includes a Source and an Entry, so will persist.
   service.Flush();
   EXPECT_EQ(GetPersistedLogCount(), 3);
 
   // Current log has no Sources.
   service.Flush();
   EXPECT_EQ(GetPersistedLogCount(), 3);
 }
 
+TEST_F(UkmServiceTest, GetNewSourceID) {
+  int32_t id1 = UkmService::GetNewSourceID();
+  int32_t id2 = UkmService::GetNewSourceID();
+  int32_t id3 = UkmService::GetNewSourceID();
+  EXPECT_NE(id1, id2);
+  EXPECT_NE(id1, id3);
+  EXPECT_NE(id2, id3);
+}
+
 }  // namespace ukm