Clean up after each MemoryCoordinatorImpl test

content/browser/memory/memory_coordinator_impl.cc

Index: content/browser/memory/memory_coordinator_impl.cc
diff --git a/content/browser/memory/memory_coordinator_impl.cc b/content/browser/memory/memory_coordinator_impl.cc
index 032a91d8333f926264a57292e0982b267b85603f..3f125fd673a5a87bfe305de7c091be5d29e04be5 100644
--- a/content/browser/memory/memory_coordinator_impl.cc
+++ b/content/browser/memory/memory_coordinator_impl.cc
@@ -176,7 +176,9 @@ MemoryCoordinatorImpl::MemoryCoordinatorImpl(
   base::MemoryCoordinatorProxy::SetMemoryCoordinator(this);
 }
 
-MemoryCoordinatorImpl::~MemoryCoordinatorImpl() {}
+MemoryCoordinatorImpl::~MemoryCoordinatorImpl() {
+  base::MemoryCoordinatorProxy::ResetGlobals();

[sadrul, 2017/03/03 17:40:41]

Maybe this could just call:
  base::MemoryCoordinatorProxy::SetMemoryCoordinator(nullptr)?

and SetMemoryCoordinator() could be updated to allow this?

[dimaa1, 2017/03/03 18:30:05]

These tests are failing because we execute this method when globals are not
reseted. We are getting crash because of the line
"DCHECK(!g_memory_coordinator);" inside that method. That is why we need to use
different way to reset it.

[sadrul, 2017/03/03 18:45:01]

Yep. That's what I suggested SetMemoryCoordinator() would need to also be
updated. For example, instead of:

  DCHECK(!g_memory_coordinator);

it could check:

  DCHECK(!g_memory_coordinator || !coordinator);

i.e. you can unset the global coordinator, but cannot replace the global
coordinator with another one. Which is the behaviour we want.

[dimaa1, 2017/03/03 18:52:02]

Great idea!

+}
 
 void MemoryCoordinatorImpl::Start() {
   DCHECK(CalledOnValidThread());