Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 272693002: Make HTMLAnchorElement.text getter behave according to specification (Closed)

Created:
6 years, 7 months ago by Inactive
Modified:
6 years, 7 months ago
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Make HTMLAnchorElement.text getter behave according to specification Make HTMLAnchorElement.text getter behave according to specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/text-level-semantics.html#dom-a-text According to the specification, the 'text' IDL attribute, on getting, must return the same value as the textContent IDL attribute on the element. However, Chromium was returning 'innerText' instead. Upon setting, Chromium was correctly updating the 'textContent' attribute though. The new behavior is consistent with Firefox 29 and IE11. This CL is based on arv's comment at: https://codereview.chromium.org/263353004/#msg2 R=arv@chromium.org, tkent@chromium.org BUG=369950 TEST=fast/dom/HTMLAnchorElement/get-text.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -14 lines) Patch
A LayoutTests/fast/dom/HTMLAnchorElement/get-text.html View 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLAnchorElement/get-text-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/html/HTMLAnchorElement.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/html/HTMLAnchorElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
6 years, 7 months ago (2014-05-07 22:08:18 UTC) #1
arv (Not doing code reviews)
LGTM
6 years, 7 months ago (2014-05-07 22:52:46 UTC) #2
tkent
lgtm
6 years, 7 months ago (2014-05-07 23:15:53 UTC) #3
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 7 months ago (2014-05-07 23:50:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/272693002/1
6 years, 7 months ago (2014-05-07 23:51:32 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 00:07:16 UTC) #6
Message was sent while issue was closed.
Change committed as 173579

Powered by Google App Engine
This is Rietveld 408576698