Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2726923003: CompletionSuggestion API for arg list text ranges. (Closed)

Created:
3 years, 9 months ago by pquitslund
Modified:
3 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added API example. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -4 lines) Patch
M pkg/analysis_server/doc/api.html View 1 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart View 1 10 chunks +37 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/CompletionSuggestion.java View 1 10 chunks +35 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
3 years, 9 months ago (2017-03-01 23:50:44 UTC) #2
Brian Wilkerson
lgtm https://codereview.chromium.org/2726923003/diff/1/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/2726923003/diff/1/pkg/analysis_server/tool/spec/spec_input.html#newcode2447 pkg/analysis_server/tool/spec/spec_input.html:2447: default argument source contents. An example would help ...
3 years, 9 months ago (2017-03-02 00:00:53 UTC) #3
pquitslund
Thanks! Landing with an example. If it's unclear, happy to follow-up with some word-smithing. https://codereview.chromium.org/2726923003/diff/1/pkg/analysis_server/tool/spec/spec_input.html ...
3 years, 9 months ago (2017-03-02 00:09:40 UTC) #4
pquitslund
3 years, 9 months ago (2017-03-02 00:10:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b17f4b2b5db76475cfaa587a70c1fdadd028a408 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698