presubmit_canned_checks.py - Issue 27269002: Suggest interactive owners tool when suggesting owners.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 27269002: Suggest interactive owners tool when suggesting owners. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index f75b9c861c670dd01baefeb5fe61840ac14c9b00..929fa5e62db6fa9eb8c04eb4e8e5e6c6028053b0 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -823,8 +823,9 @@ def CheckOwners(input_api, output_api, source_file_filter=None,

(needed, '\n '.join(sorted(missing_files))))]

if not input_api.is_committing:

suggested_owners = owners_db.reviewers_for(missing_files, owner_email)

- output_list.append(output('Suggested OWNERS:\n %s' %

- ('\n '.join(suggested_owners or []))))

+ output_list.append(output('Suggested OWNERS: ' +

+ '(Use "owners" command to interactively select owners.)\n %s' %

Dirk Pranke 2013/10/14 23:33:03 "git-cl owners", maybe?

scheib 2013/10/14 23:53:14 Done.

+ ('\n '.join(suggested_owners or []))))

return output_list

if input_api.is_committing and not reviewers:

« no previous file with comments | « no previous file | no next file » | no next file with comments »