Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 27269002: Suggest interactive owners tool when suggesting owners. (Closed)

Created:
7 years, 2 months ago by scheib
Modified:
7 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Suggest interactive owners tool when suggesting owners. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=228565

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M presubmit_canned_checks.py View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scheib
7 years, 2 months ago (2013-10-14 23:30:27 UTC) #1
Dirk Pranke
lgtm https://codereview.chromium.org/27269002/diff/3001/presubmit_canned_checks.py File presubmit_canned_checks.py (right): https://codereview.chromium.org/27269002/diff/3001/presubmit_canned_checks.py#newcode827 presubmit_canned_checks.py:827: '(Use "owners" command to interactively select owners.)\n %s' ...
7 years, 2 months ago (2013-10-14 23:33:02 UTC) #2
scheib
> "git-cl owners", maybe? I first thought so, but don't we still support svn with ...
7 years, 2 months ago (2013-10-14 23:34:08 UTC) #3
Dirk Pranke
It is still supported, but there's almost no users anymore. On Mon, Oct 14, 2013 ...
7 years, 2 months ago (2013-10-14 23:42:08 UTC) #4
scheib
https://codereview.chromium.org/27269002/diff/3001/presubmit_canned_checks.py File presubmit_canned_checks.py (right): https://codereview.chromium.org/27269002/diff/3001/presubmit_canned_checks.py#newcode827 presubmit_canned_checks.py:827: '(Use "owners" command to interactively select owners.)\n %s' % ...
7 years, 2 months ago (2013-10-14 23:53:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/27269002/10001
7 years, 2 months ago (2013-10-14 23:53:19 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-14 23:55:34 UTC) #7
Message was sent while issue was closed.
Change committed as 228565

Powered by Google App Engine
This is Rietveld 408576698