Views/Permissions: Update desktop UI to display BLOCK for embargoed permissions.

chrome/browser/permissions/permission_util.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_UTIL_H_
 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_UTIL_H_
 
 #include <string>
 
 #include "base/macros.h"
@@ skipping 43 matching lines @@
   static PermissionRequestGestureType GetGestureType(bool user_gesture);
 
   // Limited conversion of ContentSettingsType to PermissionType. Returns true
   // if the conversion was performed.
   // TODO(timloh): Try to remove this function. Mainly we need to work out how
   // to remove the usage in PermissionUmaUtil, which uses PermissionType as a
   // histogram value to count permission request metrics.
   static bool GetPermissionType(ContentSettingsType type,
                                 content::PermissionType* out);
 
+  // Checks whether the given ContentSettingsType is a permission.
+  static bool IsPermission(ContentSettingsType type);

[dominickn, 2017/03/03 03:31:36]

Perhaps move this method to the anonymous namespace in
permission_selector_row.cc? We're still working out what the best way of
handling this is, so for now it might be best to avoid polluting too many files.
:)

[Patti Lor, 2017/03/03 05:16:32]

I used this in website_settings.cc as well D:

What about getting rid of it in permission_selector_row.cc by adding a new
SettingSource::KILL_SWITCH or similar? I'm not sure if overlapping
PermissionStatusSource and SettingSource is what you want though.

Alternatively we could just use GetPermissionType() from above which already has
a TODO on it and refactor all of this when a better way to distinguish between a
permission / normal content setting is worked out?

+
   static bool ShouldShowPersistenceToggle();
 
   // A scoped class that will check the current resolved content setting on
   // construction and report a revocation metric accordingly if the revocation
   // condition is met (from ALLOW to something else).
   class ScopedRevocationReporter {
    public:
     ScopedRevocationReporter(Profile* profile,
                              const GURL& primary_url,
                              const GURL& secondary_url,
@@ skipping 15 matching lines @@
     ContentSettingsType content_type_;
     PermissionSourceUI source_ui_;
     bool is_initially_allowed_;
   };
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(PermissionUtil);
 };
 
 #endif  // CHROME_BROWSER_PERMISSIONS_PERMISSION_UTIL_H_