Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js

Issue 2726823004: Show 'inactive' cookies (fix after https://codereview.chromium.org/2714913002 ). (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js
diff --git a/third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js b/third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js
index 5076c466d9a33def4af8e24e4d10536769232541..cfed4dd10d4b3ffac38ec9f6e043c73f68cbceb1 100644
--- a/third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js
+++ b/third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js
@@ -37,15 +37,13 @@ CookieTable.CookiesTable = class extends UI.VBox {
* @param {function()=} refreshCallback
* @param {function()=} selectedCallback
* @param {function(!SDK.Cookie, function())=} deleteCallback
- * @param {string=} cookieDomain
*/
- constructor(saveCallback, refreshCallback, selectedCallback, deleteCallback, cookieDomain) {
+ constructor(saveCallback, refreshCallback, selectedCallback, deleteCallback) {
super();
this._saveCallback = saveCallback;
this._refreshCallback = refreshCallback;
this._deleteCallback = deleteCallback;
- this._cookieDomain = cookieDomain;
var editable = !!saveCallback;
@@ -105,6 +103,9 @@ CookieTable.CookiesTable = class extends UI.VBox {
this._dataGrid.asWidget().show(this.element);
this._data = [];
+
+ /** @type {string} */
+ this._cookieDomain = '';
}
/**
@@ -123,6 +124,13 @@ CookieTable.CookiesTable = class extends UI.VBox {
}
/**
+ * @param {string} cookieDomain
+ */
+ setCookieDomain(cookieDomain) {
+ this._cookieDomain = cookieDomain;
+ }
+
+ /**
* @return {?SDK.Cookie}
*/
selectedCookie() {
@@ -206,8 +214,8 @@ CookieTable.CookiesTable = class extends UI.VBox {
this._populateNode(this._dataGrid.rootNode(), item.cookies, selectedCookie, lastEditedColumnId);
}
}
- if (selectedCookie && lastEditedColumnId && !this._dataGrid.selectedNode)
- this._addInactiveNode(this._dataGrid.rootNode(), selectedCookie, lastEditedColumnId);
+ if (selectionCookies.current && lastEditedColumnId && !this._dataGrid.selectedNode)
+ this._addInactiveNode(this._dataGrid.rootNode(), selectionCookies.current, lastEditedColumnId);
if (this._saveCallback)
this._dataGrid.addCreationNode(false);
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698