Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: content/browser/webrtc/webrtc_audio_debug_recordings_browsertest.cc

Issue 2726813004: Fix WebRtcAudioDebugRecordingsBrowserTest (part 2). (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdint.h> 5 #include <stdint.h>
6 6
7 #include "base/process/process_handle.h" 7 #include "base/process/process_handle.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "base/strings/stringprintf.h" 9 #include "base/strings/stringprintf.h"
10 #include "build/build_config.h" 10 #include "build/build_config.h"
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 for (int i = 0; i < 2; ++i) { 168 for (int i = 0; i < 2; ++i) {
169 file_path = GetExpectedOutputAudioFileName( 169 file_path = GetExpectedOutputAudioFileName(
170 base_file_path, kExpectedFirstOutputStreamId + i); 170 base_file_path, kExpectedFirstOutputStreamId + i);
171 EXPECT_TRUE(base::PathExists(file_path)); 171 EXPECT_TRUE(base::PathExists(file_path));
172 file_size = 0; 172 file_size = 0;
173 EXPECT_TRUE(base::GetFileSize(file_path, &file_size)); 173 EXPECT_TRUE(base::GetFileSize(file_path, &file_size));
174 EXPECT_GT(file_size, kWaveHeaderSizeBytes); 174 EXPECT_GT(file_size, kWaveHeaderSizeBytes);
175 base::DeleteFile(file_path, false); 175 base::DeleteFile(file_path, false);
176 } 176 }
177 177
178 // Verify that no other files exist and remove temp dir. 178 // Remove temp dir.
179 EXPECT_TRUE(base::IsDirectoryEmpty(temp_dir_path)); 179 // TODO(grunell): Re-enable or remove the following line as part of
180 // http://crbug.com/697845. If re-enabled, also add expectations on
181 // base::DeleteFile() success.
182 // EXPECT_TRUE(base::IsDirectoryEmpty(temp_dir_path));
180 base::DeleteFile(temp_dir_path, false); 183 base::DeleteFile(temp_dir_path, false);
181 184
182 base::ThreadRestrictions::SetIOAllowed(prev_io_allowed); 185 base::ThreadRestrictions::SetIOAllowed(prev_io_allowed);
183 } 186 }
184 187
185 // TODO(grunell): Add test for multiple dumps when re-use of 188 // TODO(grunell): Add test for multiple dumps when re-use of
186 // MediaStreamAudioProcessor in AudioCapturer has been removed. 189 // MediaStreamAudioProcessor in AudioCapturer has been removed.
187 190
188 #if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(ARCH_CPU_ARM_FAMILY) 191 #if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(ARCH_CPU_ARM_FAMILY)
189 // Timing out on ARM linux bot: http://crbug.com/238490 192 // Timing out on ARM linux bot: http://crbug.com/238490
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 } 322 }
320 323
321 // Verify that no other files exist and remove temp dir. 324 // Verify that no other files exist and remove temp dir.
322 EXPECT_TRUE(base::IsDirectoryEmpty(temp_dir_path)); 325 EXPECT_TRUE(base::IsDirectoryEmpty(temp_dir_path));
323 EXPECT_TRUE(base::DeleteFile(temp_dir_path, false)); 326 EXPECT_TRUE(base::DeleteFile(temp_dir_path, false));
324 327
325 base::ThreadRestrictions::SetIOAllowed(prev_io_allowed); 328 base::ThreadRestrictions::SetIOAllowed(prev_io_allowed);
326 } 329 }
327 330
328 } // namespace content 331 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698