[Resources] Use the new product logo in several places

chrome/browser/themes/theme_service.cc

Index: chrome/browser/themes/theme_service.cc
diff --git a/chrome/browser/themes/theme_service.cc b/chrome/browser/themes/theme_service.cc
index 77549f419546b8feaac74f794bdafe4105f94d06..63735ff8e8aba56d216c787dad797f8ed7465ef9 100644
--- a/chrome/browser/themes/theme_service.cc
+++ b/chrome/browser/themes/theme_service.cc
@@ -744,11 +744,6 @@ int ThemeService::GetDisplayProperty(int id) const {
 base::RefCountedMemory* ThemeService::GetRawData(
     int id,
     ui::ScaleFactor scale_factor) const {
-  // Check to see whether we should substitute some images.
-  int ntp_alternate = GetDisplayProperty(ThemeProperties::NTP_LOGO_ALTERNATE);
-  if (id == IDR_PRODUCT_LOGO && ntp_alternate != 0)

[Evan Stade, 2017/03/08 17:56:30]

are you sure this code is dead? It seems to be hit when I open the app page with
a custom theme.

If this code is dead, we also don't need NTP_LOGO_ALTERNATE any more do we?

[Mathieu, 2017/03/08 18:20:22]

I am certain. I instrumented the codepaths in this file and theme_source.cc and
the image fetch goes through ThemeSource::SendThemeBitmap (which just gets it
from the resource bundle). 

NTP_LOGO_ALTERNATE as a property is still used by the current NTP [1].

[1]
https://cs.chromium.org/chromium/src/chrome/browser/search/instant_service.cc...

-    id = IDR_PRODUCT_LOGO_WHITE;
-
   base::RefCountedMemory* data = nullptr;
   if (theme_supplier_)
     data = theme_supplier_->GetRawData(id, scale_factor);