echo analysis options information if dartanalyzer --verbose is specified

echo analysis options information if dartanalyzer --verbose is specified

With this change, if the dartanalyzer --verbose option is specified
then you will see additional output indicating which analysis options
file was read:

Loaded analysis options from /path/to/.analysis_options

In addition, if there are any command line flags that specify/override
an analysis option then you will see something similar to this:

Analysis options: strong = true

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/0c290ae4563560713b801c59614718b5ad4a28e3

[danrubel, 2017-03-01 01:35:38]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2017-03-01 01:42:06]

lgtm

https://codereview.chromium.org/2726783002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/builder.dart (right):

https://codereview.chromium.org/2726783002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/builder.dart:397: verbose('Exception: $e\n  when
loading ${optionsFile.path}');
Do we need to repeat the option file path? Seems like it should be printed on
the line above.

Maybe indent the line with "Exception"?

[danrubel, 2017-03-01 01:47:04]

https://codereview.chromium.org/2726783002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/builder.dart (right):

https://codereview.chromium.org/2726783002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/builder.dart:397: verbose('Exception: $e\n  when
loading ${optionsFile.path}');
On 2017/03/01 01:42:06, Brian Wilkerson wrote:
> Do we need to repeat the option file path? Seems like it should be printed on
> the line above.
> 
> Maybe indent the line with "Exception"?

If an exception happens, it will never reach the verbose call in the try block.
I wanted the message after the operation to indicate that everything was
successful.

[danrubel, 2017-03-01 01:49:51]

Description was changed from

==========
echo analysis options information if dartanalyzer --verbose is specified

With this change, if the dartanalyzer --verbose option is specified
then you will see additional output indicating which analysis options
file was read:

Loaded analysis options from /path/to/.analysis_options

In addition, if there are any command line flags that specify/override
an analysis option then you will see something similar to this:

Analysis options: strong = true
==========

to

==========
echo analysis options information if dartanalyzer --verbose is specified

With this change, if the dartanalyzer --verbose option is specified
then you will see additional output indicating which analysis options
file was read:

Loaded analysis options from /path/to/.analysis_options

In addition, if there are any command line flags that specify/override
an analysis option then you will see something similar to this:

Analysis options: strong = true

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0c290ae4563560713b801c59614718b5ad4a28e3
==========

[danrubel, 2017-03-01 01:49:52]

Committed patchset #2 (id:20001) manually as
0c290ae4563560713b801c59614718b5ad4a28e3 (presubmit successful).