Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2726753003: Fix cascade tests with Fasta. (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix cascade tests with Fasta. There are still failing cascade tests, but these are because of parsing differences, not because of problems with the test implementation. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/270a6900f686599b8e43d10d4acac82f7b5d4c0e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -79 lines) Patch
M pkg/analyzer/test/generated/parser_fasta_test.dart View 6 chunks +2 lines, -79 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 9 months ago (2017-03-01 19:41:52 UTC) #1
Paul Berry
lgtm
3 years, 9 months ago (2017-03-01 19:43:41 UTC) #2
scheglov
3 years, 9 months ago (2017-03-01 19:45:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
270a6900f686599b8e43d10d4acac82f7b5d4c0e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698