Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h

Issue 2726733004: [Experimental] Implement some part of custom properties in style maps (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
diff --git a/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h b/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
index 62334aa709cb7f1984ed7be89597a8d4fbb37484..700834cae1d76457dff8d9d87cf8dd71fba00e1f 100644
--- a/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
+++ b/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
@@ -32,7 +32,6 @@ class CORE_EXPORT ComputedStylePropertyMap : public ImmutableStylePropertyMap {
Vector<String> getProperties() override;
DEFINE_INLINE_VIRTUAL_TRACE() {
- visitor->trace(m_computedStyleDeclaration);
visitor->trace(m_node);
ImmutableStylePropertyMap::trace(visitor);
}
@@ -43,19 +42,16 @@ class CORE_EXPORT ComputedStylePropertyMap : public ImmutableStylePropertyMap {
protected:
ComputedStylePropertyMap(Node* node, const String& pseudoElement = String())
: ImmutableStylePropertyMap(),
- m_computedStyleDeclaration(
- CSSComputedStyleDeclaration::create(node, false, pseudoElement)),
m_pseudoId(CSSSelector::parsePseudoId(pseudoElement)),
m_node(node) {}
CSSStyleValueVector getAllInternal(CSSPropertyID) override;
- CSSStyleValueVector getAllInternal(AtomicString customPropertyName) override;
+ CSSStyleValueVector getAllInternal(String customPropertyName) override;
HeapVector<StylePropertyMapEntry> getIterationEntries() override {
return HeapVector<StylePropertyMapEntry>();
}
- Member<CSSComputedStyleDeclaration> m_computedStyleDeclaration;
PseudoId m_pseudoId;
meade_UTC10 2017/03/02 00:16:59 I think these members should be private; if you mo
Member<Node> m_node;
};

Powered by Google App Engine
This is Rietveld 408576698