sandbox/win/src/handle_closer_test.cc - Issue 2726733003: CSRSS lockdown: destroy CSRSS heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/win/src/handle_closer_test.cc

Issue 2726733003: CSRSS lockdown: destroy CSRSS heap (Closed)

Patch Set: Merge branch 'master' of https://chromium.googlesource.com/chromium/src into destroy_heap Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/win/src/handle_closer_test.cc

diff --git a/sandbox/win/src/handle_closer_test.cc b/sandbox/win/src/handle_closer_test.cc

index 1e0ab4983945b8c1ed8da54c7498b12891b01f70..7e8e732c886507116cbe5de20042e937d31a84f4 100644

--- a/sandbox/win/src/handle_closer_test.cc

+++ b/sandbox/win/src/handle_closer_test.cc

@@ -289,10 +289,9 @@ TEST(HandleCloserTest, RunThreadPool) {

TestRunner runner;

runner.SetTimeout(2000);

runner.SetTestState(AFTER_REVERT);

- sandbox::TargetPolicy* policy = runner.GetPolicy();

- // Sever the CSRSS connection by closing ALPC ports inside the sandbox.

- CHECK_EQ(policy->AddKernelObjectToClose(L"ALPC Port", NULL), SBOX_ALL_OK);

+ // Sandbox policy will determine which platforms to disconnect CSRSS and when

+ // to close the CSRSS handle.

EXPECT_EQ(SBOX_TEST_SUCCEEDED, runner.RunTest(L"RunThreadPool"));

}