Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 272673002: Move paints to the front of draw structs. (Closed)

Created:
6 years, 7 months ago by mtklein_C
Modified:
6 years, 7 months ago
Reviewers:
f(malita), mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Move paints to the front of draw structs. The order of arguments in these structs is arbitrary, so we might as well arrange them to optimize something. Putting the paints at the front means the logic to find the paint is a lot more concise: it's usually just ptr+0, or *(ptr+0) when the SkPaint is optional. This considerably reduces the size of the jump table in IsDraw::operator(). BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14634

Patch Set 1 #

Patch Set 2 : dumper too #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -61 lines) Patch
M src/record/SkRecordOpts.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/record/SkRecorder.cpp View 3 chunks +29 lines, -21 lines 0 comments Download
M src/record/SkRecords.h View 1 4 chunks +42 lines, -38 lines 0 comments Download
M tests/RecordTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 7 months ago (2014-05-07 22:32:14 UTC) #1
f(malita)
lgtm
6 years, 7 months ago (2014-05-07 22:51:33 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 7 months ago (2014-05-07 22:53:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/272673002/30001
6 years, 7 months ago (2014-05-07 22:53:44 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-07 22:59:41 UTC) #5
Message was sent while issue was closed.
Change committed as 14634

Powered by Google App Engine
This is Rietveld 408576698