Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: third_party/WebKit/Source/core/dom/StaticRangeTest.cpp

Issue 2726593002: Use mayNotBeMainThread() for wrapper optimization (Closed)
Patch Set: Use V8TestingScope Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/StaticRangeTest.cpp
diff --git a/third_party/WebKit/Source/core/dom/StaticRangeTest.cpp b/third_party/WebKit/Source/core/dom/StaticRangeTest.cpp
index 885cfe740028076a18a68596ff0431dfd37c8ec0..1538599b4cc9beb29c34594316a2e143aafa43be 100644
--- a/third_party/WebKit/Source/core/dom/StaticRangeTest.cpp
+++ b/third_party/WebKit/Source/core/dom/StaticRangeTest.cpp
@@ -5,6 +5,7 @@
#include "core/dom/StaticRange.h"
#include "bindings/core/v8/ExceptionState.h"
+#include "bindings/core/v8/V8BindingForTesting.h"
#include "core/dom/Element.h"
#include "core/dom/NodeList.h"
#include "core/dom/Range.h"
@@ -43,6 +44,7 @@ HTMLDocument& StaticRangeTest::document() const {
}
TEST_F(StaticRangeTest, SplitTextNodeRangeWithinText) {
+ V8TestingScope scope;
document().body()->setInnerHTML("1234");
Text* oldText = toText(document().body()->firstChild());
@@ -113,6 +115,7 @@ TEST_F(StaticRangeTest, SplitTextNodeRangeWithinText) {
}
TEST_F(StaticRangeTest, SplitTextNodeRangeOutsideText) {
+ V8TestingScope scope;
document().body()->setInnerHTML(
"<span id=\"outer\">0<span id=\"inner-left\">1</span>SPLITME<span "
"id=\"inner-right\">2</span>3</span>");
@@ -223,6 +226,7 @@ TEST_F(StaticRangeTest, SplitTextNodeRangeOutsideText) {
}
TEST_F(StaticRangeTest, InvalidToRange) {
+ V8TestingScope scope;
document().body()->setInnerHTML("1234");
Text* oldText = toText(document().body()->firstChild());
« no previous file with comments | « third_party/WebKit/Source/core/dom/RangeTest.cpp ('k') | third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698