Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h

Issue 2726593002: Use mayNotBeMainThread() for wrapper optimization (Closed)
Patch Set: Use V8TestingScope Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h b/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h
index 65702f349f55ec119d671e93c8d1587a06ec6a40..bc0ca27546ad2755bf250fb64e15a136b3ddf7e9 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h
@@ -42,7 +42,6 @@
namespace blink {
-class Node;
struct WrapperTypeInfo;
class V8DOMWrapper {
@@ -64,11 +63,6 @@ class V8DOMWrapper {
ScriptWrappable*,
const WrapperTypeInfo*,
v8::Local<v8::Object> wrapper);
- WARN_UNUSED_RESULT static v8::Local<v8::Object> associateObjectWithWrapper(
- v8::Isolate*,
- Node*,
- const WrapperTypeInfo*,
- v8::Local<v8::Object> wrapper);
static void setNativeInfo(v8::Isolate*,
v8::Local<v8::Object>,
const WrapperTypeInfo*,
@@ -125,21 +119,6 @@ inline v8::Local<v8::Object> V8DOMWrapper::associateObjectWithWrapper(
return wrapper;
}
-inline v8::Local<v8::Object> V8DOMWrapper::associateObjectWithWrapper(
- v8::Isolate* isolate,
- Node* node,
- const WrapperTypeInfo* wrapperTypeInfo,
- v8::Local<v8::Object> wrapper) {
- if (DOMDataStore::setWrapper(isolate, node, wrapperTypeInfo, wrapper)) {
- wrapperTypeInfo->wrapperCreated();
- setNativeInfo(isolate, wrapper, wrapperTypeInfo,
- ScriptWrappable::fromNode(node));
- ASSERT(hasInternalFieldsSet(wrapper));
- }
- SECURITY_CHECK(toScriptWrappable(wrapper) == ScriptWrappable::fromNode(node));
- return wrapper;
-}
-
class V8WrapperInstantiationScope {
STACK_ALLOCATED();
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8Binding.h ('k') | third_party/WebKit/Source/core/dom/DocumentTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698