Issue 2726543003: Run ExpressionParserTestMixin tests with Fasta.

Issue 2726543003: Run ExpressionParserTestMixin tests with Fasta. (Closed)

Created:
3 years, 9 months ago by scheglov

Modified:
3 years, 9 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Run ExpressionParserTestMixin tests with Fasta. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f7d379a494831c45259b0b6050f40fe4c8056de5

Patch Set 1 #

Total comments: 1

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1503 lines, -442 lines)			Patch
	M	pkg/analyzer/test/generated/parser_fasta_test.dart	View		9 chunks	+957 lines, -0 lines	1 comment	Download
	M	pkg/analyzer/test/generated/parser_test.dart	View		215 chunks	+546 lines, -442 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

lgtm https://codereview.chromium.org/2726543003/diff/1/pkg/analyzer/test/generated/parser_fasta_test.dart File pkg/analyzer/test/generated/parser_fasta_test.dart (right): https://codereview.chromium.org/2726543003/diff/1/pkg/analyzer/test/generated/parser_fasta_test.dart#newcode1690 pkg/analyzer/test/generated/parser_fasta_test.dart:1690: // TODO: implement parseSuperConstructorInvocation Nit: change to TODO(scheglov)

3 years, 9 months ago (2017-02-28 21:27:05 UTC) #2

scheglov

3 years, 9 months ago (2017-02-28 21:33:59 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f7d379a494831c45259b0b6050f40fe4c8056de5 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages