Issue 2726533002: [Fasta] Save parent in TypeDeclarationBuilder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2726533002: [Fasta] Save parent in TypeDeclarationBuilder (Closed)

Created:
3 years, 9 months ago by jensj

Modified:
3 years, 9 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

[Fasta] Save parent in TypeDeclarationBuilder I get errors with library parent not set for some tests (e.g. service tests). This fixes that. BUG= R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/773e90869cf9d358f6c3fdcdee2b4364435c6a40

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -56 lines)			Patch
M	pkg/front_end/lib/src/fasta/builder/type_declaration_builder.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/co19/co19-kernel.status	View	1	8 chunks	+0 lines, -28 lines	0 comments	Download
M	tests/language/language_kernel.status	View	1	11 chunks	+1 line, -27 lines	0 comments	Download

Total messages: 5 (2 generated)

jensj

3 years, 9 months ago (2017-02-28 14:02:30 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
773e90869cf9d358f6c3fdcdee2b4364435c6a40 (presubmit successful).