Pass Callback to TaskRunner by value and consume it on invocation (1)

components/memory_pressure/memory_pressure_monitor_unittest.cc

Index: components/memory_pressure/memory_pressure_monitor_unittest.cc
diff --git a/components/memory_pressure/memory_pressure_monitor_unittest.cc b/components/memory_pressure/memory_pressure_monitor_unittest.cc
index 139c19e1e0b2d1e0b4a92060bc9e0eb84e529fb5..985b18e669a7d88806476dce7686aff5e6753ad4 100644
--- a/components/memory_pressure/memory_pressure_monitor_unittest.cc
+++ b/components/memory_pressure/memory_pressure_monitor_unittest.cc
@@ -5,6 +5,7 @@
 #include "components/memory_pressure/memory_pressure_monitor.h"
 
 #include <memory>
+#include <utility>
 
 #include "base/bind.h"
 #include "base/task_runner.h"
@@ -37,8 +38,13 @@ class LenientMockTaskRunner {
  public:
   MOCK_METHOD3(PostDelayedTask,
                bool(const tracked_objects::Location&,
-                    const base::Closure&,
+                    base::Closure*,
                     base::TimeDelta));
+  bool PostDelayedTask(const tracked_objects::Location& from_here,
+                       base::Closure task,
+                       base::TimeDelta delay) {
+    return PostDelayedTask(from_here, &task, delay);

[gab, 2017/03/24 15:56:08]

Passing a pointer to a local variable to a mock method is unexpected IMO.

Why can't we move it? The only EXPECT_CALL entry below that cares about
PostDelayedTask() doesn't verify what's passed in anyways, we could even drop
the param and it would work I think.

[tzik, 2017/03/28 05:59:15]

Removed the Closure parameter.

This couldn't move since MOCK_METHODs don't support move only types. I think
passing the pointer of a local variable was safe as far as the handler doesn't
save the pointee, as I do in startup_task_runner_unittest.cc too.

+  }
 };
 using MockTaskRunner = testing::StrictMock<LenientMockTaskRunner>;
 
@@ -49,9 +55,9 @@ class TaskRunnerProxy : public base::TaskRunner {
   explicit TaskRunnerProxy(MockTaskRunner* mock) : mock_(mock) {}
   bool RunsTasksOnCurrentThread() const override { return true; }
   bool PostDelayedTask(const tracked_objects::Location& location,
-                       const base::Closure& closure,
+                       base::Closure closure,
                        base::TimeDelta delta) override {
-    return mock_->PostDelayedTask(location, closure, delta);
+    return mock_->PostDelayedTask(location, std::move(closure), delta);
   }
 
  private: