Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: components/subresource_filter/content/browser/content_ruleset_service_unittest.cc

Issue 2726523002: Pass Callback to TaskRunner by value and consume it on invocation (1) (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/browser/content_ruleset_service_unittest.cc
diff --git a/components/subresource_filter/content/browser/content_ruleset_service_unittest.cc b/components/subresource_filter/content/browser/content_ruleset_service_unittest.cc
index 69a64ce3c4370ef73a16951852d892e3ca738352..18a59170113e10084950c9ccd738f285d90fe6e7 100644
--- a/components/subresource_filter/content/browser/content_ruleset_service_unittest.cc
+++ b/components/subresource_filter/content/browser/content_ruleset_service_unittest.cc
@@ -13,6 +13,7 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
#include "base/callback.h"
+#include "base/callback_helpers.h"
engedy 2017/03/23 14:09:26 nit: I think this isn't actually used here.
tzik 2017/03/24 09:25:55 Removed. Right, it was needed by ResetAndReturn in
#include "base/files/file.h"
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
@@ -47,17 +48,17 @@ class TestContentBrowserClient : public ::content::ContentBrowserClient {
// ::content::ContentBrowserClient:
void PostAfterStartupTask(const tracked_objects::Location&,
const scoped_refptr<base::TaskRunner>& task_runner,
- const base::Closure& task) override {
+ base::Closure task) override {
scoped_refptr<base::TaskRunner> ui_task_runner =
content::BrowserThread::GetTaskRunnerForThread(
content::BrowserThread::UI);
EXPECT_EQ(ui_task_runner, task_runner);
- last_task_ = task;
+ last_task_ = std::move(task);
}
void RunAfterStartupTask() {
if (!last_task_.is_null())
- last_task_.Run();
+ std::move(last_task_).Run();
}
private:
« no previous file with comments | « components/memory_pressure/memory_pressure_monitor_unittest.cc ('k') | components/user_manager/fake_user_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698