third_party/WebKit/Source/platform/scheduler/child/web_task_runner_impl.cc - Issue 2726523002: Pass Callback to TaskRunner by value and consume it on invocation (1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/child/web_task_runner_impl.cc

Issue 2726523002: Pass Callback to TaskRunner by value and consume it on invocation (1) (Closed)

Patch Set: s/base::ResetAndReturn/std::move/ Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc ('K') | « third_party/WebKit/Source/platform/scheduler/child/web_task_runner_impl.h ('k') | third_party/WebKit/Source/platform/scheduler/test/fake_web_task_runner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/child/web_task_runner_impl.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/child/web_task_runner_impl.cc b/third_party/WebKit/Source/platform/scheduler/child/web_task_runner_impl.cc

index e2dc0e49675a2b27f22bcc04b0c84cbc50f981d8..f3402943275de66e139c438966fc8bdb80a33c36 100644

--- a/third_party/WebKit/Source/platform/scheduler/child/web_task_runner_impl.cc

+++ b/third_party/WebKit/Source/platform/scheduler/child/web_task_runner_impl.cc

@@ -4,6 +4,8 @@

#include "platform/scheduler/child/web_task_runner_impl.h"

+#include <utility>

#include "base/bind.h"

#include "base/location.h"

#include "base/memory/ptr_util.h"

@@ -20,11 +22,11 @@ RefPtr<WebTaskRunnerImpl> WebTaskRunnerImpl::create(

}

void WebTaskRunnerImpl::postDelayedTask(const WebTraceLocation& location,

- const base::Closure& task,

+ base::Closure task,

double delayMs) {

DCHECK_GE(delayMs, 0.0) << location.function_name() << " "

<< location.file_name();

- task_queue_->PostDelayedTask(location, task,

+ task_queue_->PostDelayedTask(location, std::move(task),

base::TimeDelta::FromMillisecondsD(delayMs));

}