Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Unified Diff: remoting/base/auto_thread_task_runner.cc

Issue 2726523002: Pass Callback to TaskRunner by value and consume it on invocation (1) (Closed)
Patch Set: s/base::ResetAndReturn/std::move/ Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/base/auto_thread_task_runner.cc
diff --git a/remoting/base/auto_thread_task_runner.cc b/remoting/base/auto_thread_task_runner.cc
index f155cbc34607e6f2add5a27180704004af2fcae2..be997110dc80735d0670dc3f52b888b3a1acfe64 100644
--- a/remoting/base/auto_thread_task_runner.cc
+++ b/remoting/base/auto_thread_task_runner.cc
@@ -4,31 +4,33 @@
#include "remoting/base/auto_thread_task_runner.h"
+#include <utility>
+
#include "base/logging.h"
namespace remoting {
AutoThreadTaskRunner::AutoThreadTaskRunner(
scoped_refptr<base::SingleThreadTaskRunner> task_runner,
- const base::Closure& stop_task)
- : stop_task_(stop_task),
- task_runner_(task_runner) {
+ base::Closure stop_task)
+ : stop_task_(std::move(stop_task)), task_runner_(task_runner) {
DCHECK(!stop_task_.is_null());
}
bool AutoThreadTaskRunner::PostDelayedTask(
const tracked_objects::Location& from_here,
- const base::Closure& task,
+ base::Closure task,
base::TimeDelta delay) {
- CHECK(task_runner_->PostDelayedTask(from_here, task, delay));
+ CHECK(task_runner_->PostDelayedTask(from_here, std::move(task), delay));
return true;
}
bool AutoThreadTaskRunner::PostNonNestableDelayedTask(
const tracked_objects::Location& from_here,
- const base::Closure& task,
+ base::Closure task,
base::TimeDelta delay) {
- CHECK(task_runner_->PostNonNestableDelayedTask(from_here, task, delay));
+ CHECK(task_runner_->PostNonNestableDelayedTask(from_here, std::move(task),
+ delay));
return true;
}
@@ -37,7 +39,7 @@ bool AutoThreadTaskRunner::RunsTasksOnCurrentThread() const {
}
AutoThreadTaskRunner::~AutoThreadTaskRunner() {
- CHECK(task_runner_->PostTask(FROM_HERE, stop_task_));
+ CHECK(task_runner_->PostTask(FROM_HERE, std::move(stop_task_)));
}
} // namespace remoting

Powered by Google App Engine
This is Rietveld 408576698