Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3346)

Unified Diff: base/task_scheduler/task.cc

Issue 2726523002: Pass Callback to TaskRunner by value and consume it on invocation (1) (Closed)
Patch Set: s/base::ResetAndReturn/std::move/ Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/task.cc
diff --git a/base/task_scheduler/task.cc b/base/task_scheduler/task.cc
index bf3bbbd5c19d041acc197ac7c114cadcc8f43996..44aaa6016ddda0a159f8c39660246dae63390990 100644
--- a/base/task_scheduler/task.cc
+++ b/base/task_scheduler/task.cc
@@ -4,20 +4,22 @@
#include "base/task_scheduler/task.h"
+#include <utility>
+
#include "base/critical_closure.h"
namespace base {
namespace internal {
Task::Task(const tracked_objects::Location& posted_from,
- const Closure& task,
+ Closure task,
const TaskTraits& traits,
TimeDelta delay)
: PendingTask(
posted_from,
traits.shutdown_behavior() == TaskShutdownBehavior::BLOCK_SHUTDOWN
- ? MakeCriticalClosure(task)
- : task,
+ ? MakeCriticalClosure(std::move(task))
+ : std::move(task),
delay.is_zero() ? TimeTicks() : TimeTicks::Now() + delay,
false), // Not nestable.
// Prevent a delayed BLOCK_SHUTDOWN task from blocking shutdown before

Powered by Google App Engine
This is Rietveld 408576698