Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: third_party/WebKit/Source/platform/scheduler/child/compositor_worker_scheduler.cc

Issue 2726523002: Pass Callback to TaskRunner by value and consume it on invocation (1) (Closed)
Patch Set: erase Closure* Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "public/platform/scheduler/child/compositor_worker_scheduler.h" 5 #include "public/platform/scheduler/child/compositor_worker_scheduler.h"
6 6
7 #include <utility>
8
9 #include "base/callback.h"
7 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
8 #include "base/threading/thread.h" 11 #include "base/threading/thread.h"
9 12
10 namespace blink { 13 namespace blink {
11 namespace scheduler { 14 namespace scheduler {
12 15
13 // TODO(scheduler-dev): Get rid of this asap! 16 // TODO(scheduler-dev): Get rid of this asap!
14 namespace { 17 namespace {
15 class CompositorWorkerTaskRunnerWrapper : public TaskQueue { 18 class CompositorWorkerTaskRunnerWrapper : public TaskQueue {
16 public: 19 public:
17 explicit CompositorWorkerTaskRunnerWrapper( 20 explicit CompositorWorkerTaskRunnerWrapper(
18 scoped_refptr<base::SingleThreadTaskRunner> task_runner) 21 scoped_refptr<base::SingleThreadTaskRunner> task_runner)
19 : task_runner_(task_runner) {} 22 : task_runner_(task_runner) {}
20 23
21 // TaskQueue implementation: 24 // TaskQueue implementation:
22 void UnregisterTaskQueue() override { NOTREACHED(); } 25 void UnregisterTaskQueue() override { NOTREACHED(); }
23 26
24 bool RunsTasksOnCurrentThread() const override { 27 bool RunsTasksOnCurrentThread() const override {
25 return task_runner_->RunsTasksOnCurrentThread(); 28 return task_runner_->RunsTasksOnCurrentThread();
26 } 29 }
27 30
28 bool PostDelayedTask(const tracked_objects::Location& from_here, 31 bool PostDelayedTask(const tracked_objects::Location& from_here,
29 const base::Closure& task, 32 base::Closure task,
30 base::TimeDelta delay) override { 33 base::TimeDelta delay) override {
31 return task_runner_->PostDelayedTask(from_here, task, delay); 34 return task_runner_->PostDelayedTask(from_here, std::move(task), delay);
32 } 35 }
33 36
34 bool PostNonNestableDelayedTask(const tracked_objects::Location& from_here, 37 bool PostNonNestableDelayedTask(const tracked_objects::Location& from_here,
35 const base::Closure& task, 38 base::Closure task,
36 base::TimeDelta delay) override { 39 base::TimeDelta delay) override {
37 return task_runner_->PostNonNestableDelayedTask(from_here, task, delay); 40 return task_runner_->PostNonNestableDelayedTask(from_here, std::move(task),
41 delay);
38 } 42 }
39 43
40 std::unique_ptr<QueueEnabledVoter> CreateQueueEnabledVoter() override { 44 std::unique_ptr<QueueEnabledVoter> CreateQueueEnabledVoter() override {
41 NOTREACHED(); 45 NOTREACHED();
42 return nullptr; 46 return nullptr;
43 } 47 }
44 48
45 void InsertFence(InsertFencePosition position) override { NOTREACHED(); } 49 void InsertFence(InsertFencePosition position) override { NOTREACHED(); }
46 50
47 void RemoveFence() override { NOTREACHED(); } 51 void RemoveFence() override { NOTREACHED(); }
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 } 178 }
175 179
176 void CompositorWorkerScheduler::DidProcessIdleTask() {} 180 void CompositorWorkerScheduler::DidProcessIdleTask() {}
177 181
178 base::TimeTicks CompositorWorkerScheduler::NowTicks() { 182 base::TimeTicks CompositorWorkerScheduler::NowTicks() {
179 return base::TimeTicks::Now(); 183 return base::TimeTicks::Now();
180 } 184 }
181 185
182 } // namespace scheduler 186 } // namespace scheduler
183 } // namespace blink 187 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698