Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: base/task_scheduler/task.cc

Issue 2726523002: Pass Callback to TaskRunner by value and consume it on invocation (1) (Closed)
Patch Set: erase Closure* Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/task_scheduler/task.h ('k') | base/task_scheduler/task_scheduler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/task_scheduler/task.h" 5 #include "base/task_scheduler/task.h"
6 6
7 #include <utility>
8
7 #include "base/critical_closure.h" 9 #include "base/critical_closure.h"
8 10
9 namespace base { 11 namespace base {
10 namespace internal { 12 namespace internal {
11 13
12 Task::Task(const tracked_objects::Location& posted_from, 14 Task::Task(const tracked_objects::Location& posted_from,
13 const Closure& task, 15 Closure task,
14 const TaskTraits& traits, 16 const TaskTraits& traits,
15 TimeDelta delay) 17 TimeDelta delay)
16 : PendingTask( 18 : PendingTask(
17 posted_from, 19 posted_from,
18 traits.shutdown_behavior() == TaskShutdownBehavior::BLOCK_SHUTDOWN 20 traits.shutdown_behavior() == TaskShutdownBehavior::BLOCK_SHUTDOWN
19 ? MakeCriticalClosure(task) 21 ? MakeCriticalClosure(std::move(task))
20 : task, 22 : std::move(task),
21 delay.is_zero() ? TimeTicks() : TimeTicks::Now() + delay, 23 delay.is_zero() ? TimeTicks() : TimeTicks::Now() + delay,
22 false), // Not nestable. 24 false), // Not nestable.
23 // Prevent a delayed BLOCK_SHUTDOWN task from blocking shutdown before 25 // Prevent a delayed BLOCK_SHUTDOWN task from blocking shutdown before
24 // being scheduled by changing its shutdown behavior to SKIP_ON_SHUTDOWN. 26 // being scheduled by changing its shutdown behavior to SKIP_ON_SHUTDOWN.
25 traits(!delay.is_zero() && traits.shutdown_behavior() == 27 traits(!delay.is_zero() && traits.shutdown_behavior() ==
26 TaskShutdownBehavior::BLOCK_SHUTDOWN 28 TaskShutdownBehavior::BLOCK_SHUTDOWN
27 ? TaskTraits(traits).WithShutdownBehavior( 29 ? TaskTraits(traits).WithShutdownBehavior(
28 TaskShutdownBehavior::SKIP_ON_SHUTDOWN) 30 TaskShutdownBehavior::SKIP_ON_SHUTDOWN)
29 : traits), 31 : traits),
30 delay(delay) {} 32 delay(delay) {}
31 33
32 Task::~Task() = default; 34 Task::~Task() = default;
33 35
34 } // namespace internal 36 } // namespace internal
35 } // namespace base 37 } // namespace base
OLDNEW
« no previous file with comments | « base/task_scheduler/task.h ('k') | base/task_scheduler/task_scheduler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698