Pass Callback to TaskRunner by value and consume it on invocation (1)

remoting/client/plugin/pepper_main_thread_task_runner.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/plugin/pepper_main_thread_task_runner.h"
 
 #include <memory>
+#include <utility>
 
 #include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/callback_helpers.h"
 #include "base/memory/ptr_util.h"
 #include "ppapi/cpp/completion_callback.h"
 #include "ppapi/cpp/core.h"
 #include "ppapi/cpp/module.h"
 
 namespace remoting {
 namespace {
 
 void RunAndDestroy(void* task_ptr, int32_t) {
   std::unique_ptr<base::Closure> task(static_cast<base::Closure*>(task_ptr));
   task->Run();
 }
 
 }  // namespace
 
 PepperMainThreadTaskRunner::PepperMainThreadTaskRunner()
     : core_(pp::Module::Get()->core()), weak_ptr_factory_(this) {
   DCHECK(core_->IsMainThread());
   weak_ptr_ = weak_ptr_factory_.GetWeakPtr();
 }
 
 bool PepperMainThreadTaskRunner::PostDelayedTask(
     const tracked_objects::Location& from_here,
-    const base::Closure& task,
+    base::Closure task,
     base::TimeDelta delay) {
-  auto task_ptr = base::MakeUnique<base::Closure>(
-      base::Bind(&PepperMainThreadTaskRunner::RunTask, weak_ptr_, task));
+  auto task_ptr = base::MakeUnique<base::Closure>(base::Bind(
+      &PepperMainThreadTaskRunner::RunTask, weak_ptr_, base::Passed(&task)));
   core_->CallOnMainThread(
       delay.InMillisecondsRoundedUp(),
       pp::CompletionCallback(&RunAndDestroy, task_ptr.release()));
   return true;
 }
 
 bool PepperMainThreadTaskRunner::PostNonNestableDelayedTask(
     const tracked_objects::Location& from_here,
-    const base::Closure& task,
+    base::Closure task,
     base::TimeDelta delay) {
-  return PostDelayedTask(from_here, task, delay);
+  return PostDelayedTask(from_here, std::move(task), delay);
 }
 
 bool PepperMainThreadTaskRunner::RunsTasksOnCurrentThread() const {
   return core_->IsMainThread();
 }
 
 PepperMainThreadTaskRunner::~PepperMainThreadTaskRunner() {}
 
-void PepperMainThreadTaskRunner::RunTask(const base::Closure& task) {
-  task.Run();
+void PepperMainThreadTaskRunner::RunTask(base::Closure task) {
+  base::ResetAndReturn(&task).Run();

[Wez, 2017/03/21 16:43:36]

Why do you need ResetAndReturn() here?

[tzik, 2017/03/22 08:52:03]

# Converted it to std::move().

This is a preparation for base::OnceCallback, which can run only on rvalue. It's
unneeded for base::Closure, but this will make a following CL smaller.

 }
 
 }  // namespace remoting