chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc - Issue 2726433004: Disable 4 unit tests that are failing with PlzNavigate and Site Isolation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 2726433004: Disable 4 unit tests that are failing with PlzNavigate and Site Isolation. (Closed)

Patch Set: nit Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_navigation_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

index 721217283885b8fe84e878faa4155183b413a83f..4586d60a33497325e44bd8bf9b9b6c1791aa3ee9 100644

--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

@@ -10,6 +10,8 @@

#include "chrome/test/base/testing_browser_process.h"

#include "components/rappor/public/rappor_utils.h"

#include "components/rappor/test_rappor_service.h"

+#include "content/public/common/browser_side_navigation_policy.h"

+#include "content/public/test/test_utils.h"

#include "third_party/WebKit/public/platform/WebMouseEvent.h"

namespace {

@@ -304,6 +306,11 @@ TEST_F(CorePageLoadMetricsObserverTest, DontBackgroundQuickerLoad) {

}

TEST_F(CorePageLoadMetricsObserverTest, FailedProvisionalLoad) {

+ if (content::IsBrowserSideNavigationEnabled() &&

+ content::AreAllSitesIsolatedForTesting()) {

+ // http://crbug.com/674734 Fix this test with PlzNavigate and Site Isolation

+ return;

+ }

GURL url(kDefaultTestUrl);

content::RenderFrameHostTester* rfh_tester =

content::RenderFrameHostTester::For(main_rfh());