Issue 272643003: Fix for SkDisplacementMap::onFilterBounds().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 272643003: Fix for SkDisplacementMap::onFilterBounds(). (Closed)

Created:
6 years, 7 months ago by Stephen White

Modified:
6 years, 7 months ago

Reviewers:
Justin Novosad

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix for SkDisplacementMap::onFilterBounds(). Two problems: we were not applying the CTM to the scale parameter when modifying clip bounds, and the recursion for onFilterBounds() must be done in the reverse order. BUG=370914 R=junov@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=14627

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -31 lines)			Patch
	M	src/effects/SkDisplacementMapEffect.cpp	View		1 chunk	+6 lines, -4 lines	0 comments	Download
	M	tests/ImageFilterTest.cpp	View		2 chunks	+33 lines, -27 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Justin Novosad

On 2014/05/07 19:19:48, Stephen White wrote: > junov@: PTAL. Thanks! lgtm

6 years, 7 months ago (2014-05-07 19:49:37 UTC) #2

Stephen White

6 years, 7 months ago (2014-05-07 20:00:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14627 (presubmit successful).

Expand Messages | Collapse Messages