Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: chrome/browser/resources/settings/BUILD.gn

Issue 2726403003: WebUI: Split unpack_pak functionality to its own GN action. (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/unpack_pak.py » ('j') | chrome/browser/resources/unpack_pak.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/BUILD.gn
diff --git a/chrome/browser/resources/settings/BUILD.gn b/chrome/browser/resources/settings/BUILD.gn
index 8a905acd624b42b856ac872fbbd30a45ccd07e7f..5bc5ff9f338cfd34786218ec52b3650748829eba 100644
--- a/chrome/browser/resources/settings/BUILD.gn
+++ b/chrome/browser/resources/settings/BUILD.gn
@@ -3,17 +3,27 @@ import("//tools/grit/grit_rule.gni")
import("//chrome/common/features.gni")
vulcanized_unbuilt = "vulcanized.unbuilt.html"
+settings_pak_file = "settings_resources.pak"
+unpack_pak_folder = "settings_resources.unpak"
Dan Beam 2017/03/10 00:10:32 nit: unpack_pak -> unpak everywhere? ;)
dpapad 2017/03/10 01:42:31 Done (except from renaming unpack_pak.py itself).
vulcanize("vulcanize") {
host = "md-settings"
html_in_file = "settings.html"
html_out_file = vulcanized_unbuilt
insert_in_head = "<base href=\"chrome://\$i18n{hostname}\">"
- input = rebase_path(root_gen_dir, root_build_dir) +
- "/chrome/browser/resources/settings/settings_resources.pak"
+ input = rebase_path("$target_gen_dir/$unpack_pak_folder", root_build_dir)
js_out_file = "crisper.js"
deps = [
+ ":unpack",
+ ]
+}
+
+unpack_pak("unpack") {
+ pak_file = settings_pak_file
+ out_folder = unpack_pak_folder
+
+ deps = [
":flattened_resources",
]
}
@@ -35,7 +45,7 @@ grit("flattened_resources") {
"grit/settings_resources.h",
"grit/settings_resources_map.cc",
"grit/settings_resources_map.h",
- "settings_resources.pak",
+ settings_pak_file,
]
output_dir = "$root_gen_dir/chrome/browser/resources/settings"
}
« no previous file with comments | « no previous file | chrome/browser/resources/unpack_pak.py » ('j') | chrome/browser/resources/unpack_pak.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698