Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: chrome/browser/resources/settings/BUILD.gn

Issue 2726403003: WebUI: Split unpack_pak functionality to its own GN action. (Closed)
Patch Set: Address comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 import("../vulcanize.gni") 1 import("../vulcanize.gni")
2 import("//tools/grit/grit_rule.gni") 2 import("//tools/grit/grit_rule.gni")
3 import("//chrome/common/features.gni") 3 import("//chrome/common/features.gni")
4 4
5 vulcanized_unbuilt = "vulcanized.unbuilt.html" 5 vulcanized_unbuilt = "vulcanized.unbuilt.html"
6 settings_pak_file = "settings_resources.pak"
7 unpak_folder = "settings_resources.unpak"
6 8
7 vulcanize("vulcanize") { 9 vulcanize("vulcanize") {
8 host = "md-settings" 10 host = "md-settings"
9 html_in_file = "settings.html" 11 html_in_file = "settings.html"
10 html_out_file = vulcanized_unbuilt 12 html_out_file = vulcanized_unbuilt
11 insert_in_head = "<base href=\"chrome://\$i18n{hostname}\">" 13 insert_in_head = "<base href=\"chrome://\$i18n{hostname}\">"
12 input = rebase_path(root_gen_dir, root_build_dir) + 14 input = rebase_path("$target_gen_dir/$unpak_folder", root_build_dir)
13 "/chrome/browser/resources/settings/settings_resources.pak"
14 js_out_file = "crisper.js" 15 js_out_file = "crisper.js"
15 16
16 deps = [ 17 deps = [
18 ":unpak",
19 ]
20 }
21
22 unpak("unpak") {
23 pak_file = settings_pak_file
24 out_folder = unpak_folder
25
26 deps = [
17 ":flattened_resources", 27 ":flattened_resources",
18 ] 28 ]
19 } 29 }
20 30
21 polymer_css_build("build") { 31 polymer_css_build("build") {
22 input_files = [ vulcanized_unbuilt ] 32 input_files = [ vulcanized_unbuilt ]
23 output_files = [ "vulcanized.html" ] 33 output_files = [ "vulcanized.html" ]
24 deps = [ 34 deps = [
25 ":vulcanize", 35 ":vulcanize",
26 ] 36 ]
27 } 37 }
28 38
29 grit("flattened_resources") { 39 grit("flattened_resources") {
30 source = "settings_resources.grd" 40 source = "settings_resources.grd"
31 defines = chrome_grit_defines 41 defines = chrome_grit_defines
32 outputs = [ 42 outputs = [
33 "grit/settings_resources.h", 43 "grit/settings_resources.h",
34 "grit/settings_resources_map.cc", 44 "grit/settings_resources_map.cc",
35 "grit/settings_resources_map.h", 45 "grit/settings_resources_map.h",
36 "settings_resources.pak", 46 settings_pak_file,
37 ] 47 ]
38 output_dir = "$root_gen_dir/chrome/browser/resources/settings" 48 output_dir = "$root_gen_dir/chrome/browser/resources/settings"
39 } 49 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/unpack_pak.py » ('j') | chrome/browser/resources/vulcanize.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698