cc: Optimize decode scheduling for checker-images.

cc/tiles/tile_manager.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_TILES_TILE_MANAGER_H_
 #define CC_TILES_TILE_MANAGER_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 264 matching lines @@
     ~PrioritizedWorkToSchedule();
 
     std::vector<PrioritizedTile> tiles_to_raster;
     std::vector<PrioritizedTile> tiles_to_process_for_images;
   };
 
   void FreeResourcesForTile(Tile* tile);
   void FreeResourcesForTileAndNotifyClientIfTileWasReadyToDraw(Tile* tile);
   scoped_refptr<TileTask> CreateRasterTask(
       const PrioritizedTile& prioritized_tile,
-      const gfx::ColorSpace& color_space);
+      const gfx::ColorSpace& color_space,
+      CheckerImageTracker::ImageDecodeQueue* checker_image_decode_queue);
 
   std::unique_ptr<EvictionTilePriorityQueue>
   FreeTileResourcesUntilUsageIsWithinLimit(
       std::unique_ptr<EvictionTilePriorityQueue> eviction_priority_queue,
       const MemoryUsage& limit,
       MemoryUsage* usage);
   std::unique_ptr<EvictionTilePriorityQueue>
   FreeTileResourcesWithLowerPriorityUntilUsageIsWithinLimit(
       std::unique_ptr<EvictionTilePriorityQueue> eviction_priority_queue,
       const MemoryUsage& limit,
@@ skipping 11 matching lines @@
 
   void DidFinishRunningTileTasksRequiredForActivation();
   void DidFinishRunningTileTasksRequiredForDraw();
   void DidFinishRunningAllTileTasks();
 
   scoped_refptr<TileTask> CreateTaskSetFinishedTask(
       void (TileManager::*callback)());
   PrioritizedWorkToSchedule AssignGpuMemoryToTiles();
   void ScheduleTasks(const PrioritizedWorkToSchedule& work_to_schedule);
 
+  void FilterImagesForCheckering(

[vmpstr, 2017/03/29 19:11:46]

This needs a comment explaining what each parameter is, since 

images_to_decode_for_raster, checkered_images, and image_decode_queue all seem
to store the same thing. Possibly, this needs to be reworked to move some code
outside of the function. 

In my mind, the output of this should be fewer vectors/sets/queues and the
calling code will then use the vector to populate/append to the queue or
something like that.

That being said, I haven't looked at the implementation yet and just commenting
on the header.

[Khushal, 2017/03/31 04:31:01]

The function was killed.

+      WhichTree tree,
+      const std::vector<DrawImage>& images_in_tile,
+      std::vector<DrawImage>* images_to_decode_for_raster,

[vmpstr, 2017/03/29 19:11:46]

just images_to_decode is enough I think.

+      ImageIdFlatSet* checkered_images,
+      CheckerImageTracker::ImageDecodeQueue* image_decode_queue);
+
   std::unique_ptr<base::trace_event::ConvertableToTraceFormat>
   ScheduledTasksStateAsValue() const;
 
   bool UsePartialRaster() const;
 
   void CheckPendingGpuWorkTiles(bool issue_signals);
 
   TileManagerClient* client_;
   base::SequencedTaskRunner* task_runner_;
   ResourcePool* resource_pool_;
@@ skipping 48 matching lines @@
   base::WeakPtrFactory<TileManager> task_set_finished_weak_ptr_factory_;
   // The |ready_to_draw_callback_weak_ptr_factory_| is never invalidated.
   base::WeakPtrFactory<TileManager> ready_to_draw_callback_weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(TileManager);
 };
 
 }  // namespace cc
 
 #endif  // CC_TILES_TILE_MANAGER_H_