cc: Optimize decode scheduling for checker-images.

cc/tiles/tile_draw_info.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_TILES_TILE_DRAW_INFO_H_
 #define CC_TILES_TILE_DRAW_INFO_H_
 
 #include <memory>
 
 #include "base/trace_event/trace_event_argument.h"
@@ skipping 59 matching lines @@
   bool requires_resource() const {
     return mode_ == RESOURCE_MODE || mode_ == OOM_MODE;
   }
 
   inline bool has_resource() const { return !!resource_; }
 
   inline bool has_compressed_resource() const {
     return resource_ ? IsResourceFormatCompressed(resource_->format()) : false;
   }
 
+  bool is_checker_imaged() const {

[vmpstr, 2017/03/29 19:11:45]

Just by looking at tile.h and tile_draw_info.h, the two flags you're adding seem
to say very similar things, so I think you need to add a comment explaining the
state. 

[Khushal, 2017/03/31 04:31:00]

Done.

+    return has_resource() && resource_is_checker_imaged_;
+  }
+
   void SetSolidColorForTesting(SkColor color) { set_solid_color(color); }
 
   void AsValueInto(base::trace_event::TracedValue* state) const;
 
  private:
   friend class Tile;
   friend class TileManager;
 
   const Resource* resource() const { return resource_; }
 
   void set_resource(Resource* resource) {
     mode_ = RESOURCE_MODE;
     is_resource_ready_to_draw_ = false;
+    resource_is_checker_imaged_ = false;

[vmpstr, 2017/03/29 19:11:45]

What if we set a resource that _is_ checker imaged?

Can you make this more robust in terms of order of operations?

That is
info.resource_is_checker_imaged_ = true;
info.set_resource(resource); 

will seem to do the wrong thing here.

Maybe add a bool to set_resource indicating whether the resource was checker
imaged with a default value of false?

[Khushal, 2017/03/29 22:10:20]

That makes sense.

[Khushal, 2017/03/31 04:31:00]

Done.

     resource_ = resource;
   }
 
   void set_resource_ready_for_draw() {
     is_resource_ready_to_draw_ = true;
   }
 
   Resource* TakeResource();
 
   void set_solid_color(const SkColor& color) {
     mode_ = SOLID_COLOR_MODE;
     solid_color_ = color;
   }
 
   void set_oom() { mode_ = OOM_MODE; }
 
   Mode mode_ = RESOURCE_MODE;
   SkColor solid_color_ = SK_ColorWHITE;
   Resource* resource_ = nullptr;
+  bool resource_is_checker_imaged_ = false;

[vmpstr, 2017/03/29 19:11:45]

I'm not really a fan of "checker_imaged" as a name. I don't really have better
suggestions, but maybe you can come up with something.

[Khushal, 2017/03/29 22:10:20]

At this point, may be just keep that for consistency? Coz everything else in the
system is called checker-imaged...

   bool contents_swizzled_ = false;
   bool is_resource_ready_to_draw_ = false;
 };
 
 }  // namespace cc
 
 #endif  // CC_TILES_TILE_DRAW_INFO_H_