Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 272633003: Force composite fast/ tests (Closed)

Created:
6 years, 7 months ago by enne (OOO)
Modified:
6 years, 7 months ago
Reviewers:
ojan, abarth-chromium
CC:
blink-reviews, danakj
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : TestExpectations #

Patch Set 3 : More expectations #

Total comments: 2

Patch Set 4 : More NeedsRebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +335 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
enne (OOO)
Mac results: https://storage.googleapis.com/chromium-layout-test-archives/mac_blink_rel/6045/layout-test-results/results.html Win results: https://storage.googleapis.com/chromium-layout-test-archives/win_blink_rel/6514/layout-test-results/results.html There are a ton of Mac failures with imperceptible ...
6 years, 7 months ago (2014-05-07 22:01:13 UTC) #1
enne (OOO)
There was one actual failure in fast/, which I filed as https://code.google.com/p/chromium/issues/detail?id=371104
6 years, 7 months ago (2014-05-07 22:01:47 UTC) #2
ojan
lgtm
6 years, 7 months ago (2014-05-07 23:26:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/272633003/40001
6 years, 7 months ago (2014-05-07 23:27:07 UTC) #4
ojan
The CQ bit was unchecked by ojan@chromium.org
6 years, 7 months ago (2014-05-07 23:30:30 UTC) #5
ojan
lgtm https://codereview.chromium.org/272633003/diff/40001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/272633003/diff/40001/LayoutTests/TestExpectations#newcode97 LayoutTests/TestExpectations:97: crbug.com/371104 fast/backgrounds/bgCompositeCopy.html [ Pass ImageOnlyFailure ] Lets just ...
6 years, 7 months ago (2014-05-07 23:31:19 UTC) #6
enne (OOO)
https://codereview.chromium.org/272633003/diff/40001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/272633003/diff/40001/LayoutTests/TestExpectations#newcode97 LayoutTests/TestExpectations:97: crbug.com/371104 fast/backgrounds/bgCompositeCopy.html [ Pass ImageOnlyFailure ] On 2014/05/07 23:31:19, ...
6 years, 7 months ago (2014-05-07 23:37:01 UTC) #7
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 7 months ago (2014-05-07 23:37:05 UTC) #8
enne (OOO)
The CQ bit was unchecked by enne@chromium.org
6 years, 7 months ago (2014-05-07 23:37:27 UTC) #9
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 7 months ago (2014-05-07 23:37:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/272633003/60001
6 years, 7 months ago (2014-05-07 23:38:35 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 00:47:27 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 02:09:01 UTC) #13
Message was sent while issue was closed.
Change committed as 173588

Powered by Google App Engine
This is Rietveld 408576698