Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2726303004: Set allow_user_segv_handler asan option

Created:
3 years, 9 months ago by Eric Holk
Modified:
3 years, 9 months ago
CC:
bradnelson
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set allow_user_segv_handler asan option V8's signal handler based bounds checking solution needs to be able to install a custom signal handler. Unfortunately, asan does not allow this by default. BUG=v8:5277

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M sanitizers/sanitizer_options.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Eric Holk
My recent attempt to land V8's out of bounds trap handler for WebAssembly ran into ...
3 years, 9 months ago (2017-03-03 23:32:58 UTC) #4
jochen (gone - plz use gerrit)
BUG= should be BUG=v8:5277 what project is this file from?
3 years, 9 months ago (2017-03-06 12:56:04 UTC) #5
Eric Holk
On 2017/03/06 12:56:04, jochen wrote: > BUG= should be BUG=v8:5277 > > what project is ...
3 years, 9 months ago (2017-03-06 19:06:38 UTC) #7
jochen (gone - plz use gerrit)
lgtm
3 years, 9 months ago (2017-03-07 11:52:19 UTC) #8
Alexander Potapenko
On 2017/03/07 11:52:19, jochen wrote: > lgtm Rubberstamp LGTM
3 years, 9 months ago (2017-03-07 12:14:34 UTC) #9
jochen (gone - plz use gerrit)
btw, build.git is a read-only copy of chromium's src/build directory - you'll have to use ...
3 years, 9 months ago (2017-03-07 15:27:38 UTC) #10
Eric Holk
3 years, 9 months ago (2017-03-07 19:09:34 UTC) #11
On 2017/03/07 15:27:38, jochen wrote:
> btw, build.git is a read-only copy of chromium's src/build directory - you'll
> have to use a full chromium checkout and upload this patch from there ..

Oops, thanks for pointing this out. I moved this CL over to
https://chromium-review.googlesource.com/c/450986/

Powered by Google App Engine
This is Rietveld 408576698