[date] Add a cache for timezone names to DateCache

src/date.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_DATE_H_
 #define V8_DATE_H_
 
 #include "src/allocation.h"
 #include "src/base/platform/platform.h"
 #include "src/globals.h"
@@ skipping 75 matching lines @@
       local_offset_ms_ = GetLocalOffsetFromOS();
     }
     return local_offset_ms_;
   }
 
 
   const char* LocalTimezone(int64_t time_ms) {
     if (time_ms < 0 || time_ms > kMaxEpochTimeInMs) {
       time_ms = EquivalentTime(time_ms);
     }
-    return base::OS::LocalTimezone(static_cast<double>(time_ms), tz_cache_);
+    bool is_dst = DaylightSavingsOffsetInMs(time_ms) != 0;
+    const char** name = is_dst ? &dst_tz_name_ : &tz_name_;

[jgruber, 2017/03/03 08:09:57]

Nit: Can you use plain 'const char* name' instead of 'const char**'?

[Dan Ehrenberg, 2017/03/03 12:57:44]

I don't think so, because then I don't see how I could write to it on line 99
and have that affect the underlying object. I could use a C++ reference, but
non-const references are discouraged in the Google style guide (though I believe
they're found all over Blink).

[jgruber, 2017/03/03 13:02:34]

Ah, gotcha. sgtm.

+    if (*name == nullptr) {
+      *name = base::OS::LocalTimezone(static_cast<double>(time_ms), tz_cache_);
+    }
+    return *name;
   }
 
   // ECMA 262 - 15.9.5.26
   int TimezoneOffset(int64_t time_ms) {
     int64_t local_ms = ToLocal(time_ms);
     return static_cast<int>((time_ms - local_ms) / kMsPerMin);
   }
 
   // ECMA 262 - 15.9.1.9
   // LocalTime(t) = t + LocalTZA + DaylightSavingTA(t)
@@ skipping 163 matching lines @@
 
   int local_offset_ms_;
 
   // Year/Month/Day cache.
   bool ymd_valid_;
   int ymd_days_;
   int ymd_year_;
   int ymd_month_;
   int ymd_day_;
 
+  // Timezone name cache
+  const char* tz_name_;
+  const char* dst_tz_name_;
+
   base::TimezoneCache* tz_cache_;
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif