Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: chrome/browser/bookmarks/bookmark_table_model.cc

Issue 27262: Wires up sorting of bookmarks to the 'organize menu' in the bookmark... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_table_model.cc
===================================================================
--- chrome/browser/bookmarks/bookmark_table_model.cc (revision 10579)
+++ chrome/browser/bookmarks/bookmark_table_model.cc (working copy)
@@ -85,8 +85,7 @@
FolderBookmarkTableModel(BookmarkModel* model, BookmarkNode* root_node)
: VectorBackedBookmarkTableModel(model),
root_node_(root_node) {
- for (int i = 0; i < root_node->GetChildCount(); ++i)
- nodes().push_back(root_node->GetChild(i));
+ PopulateNodesFromRoot();
}
virtual void BookmarkNodeMoved(BookmarkModel* model,
@@ -146,12 +145,29 @@
NotifyChanged(node);
}
+ virtual void BookmarkNodeChildrenReordered(BookmarkModel* model,
+ BookmarkNode* node) {
+ if (node != root_node_)
+ return;
+
+ nodes().clear();
+ PopulateNodesFromRoot();
+
+ if (observer())
+ observer()->OnModelChanged();
+ }
+
private:
void NotifyChanged(BookmarkNode* node) {
if (node->GetParent() == root_node_ && observer())
observer()->OnItemsChanged(node->GetParent()->IndexOfChild(node), 1);
}
+ void PopulateNodesFromRoot() {
+ for (int i = 0; i < root_node_->GetChildCount(); ++i)
+ nodes().push_back(root_node_->GetChild(i));
+ }
+
// The node we're showing the children of. This is set to NULL if the node
// (or one of its ancestors) is removed from the model.
BookmarkNode* root_node_;

Powered by Google App Engine
This is Rietveld 408576698