Source/bindings/core/v8/PageScriptDebugServer.cpp - Issue 272613002: DevTools: implemented scriptFailedToParse protocol event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/PageScriptDebugServer.cpp

Issue 272613002: DevTools: implemented scriptFailedToParse protocol event (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/inspector/sources/debugger/script-failed-to-parse.html ('K') | « LayoutTests/inspector/sources/debugger/script-failed-to-parse-expected.txt ('k') | Source/bindings/core/v8/ScriptDebugServer.h » ('j') | Source/bindings/core/v8/ScriptDebugServer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/PageScriptDebugServer.cpp

diff --git a/Source/bindings/core/v8/PageScriptDebugServer.cpp b/Source/bindings/core/v8/PageScriptDebugServer.cpp

index c33147f2c086346ce19ae82396e25cd4e503b505..7196fafd3db329b7be0860a452e0aca2df860bad 100644

--- a/Source/bindings/core/v8/PageScriptDebugServer.cpp

+++ b/Source/bindings/core/v8/PageScriptDebugServer.cpp

@@ -138,7 +138,7 @@ void PageScriptDebugServer::addListener(ScriptDebugListener* listener, Page* pag

ASSERT(!value->IsUndefined() && value->IsArray());

v8::Handle<v8::Array> scriptsArray = v8::Handle<v8::Array>::Cast(value);

for (unsigned i = 0; i < scriptsArray->Length(); ++i)

- dispatchDidParseSource(listener, v8::Handle<v8::Object>::Cast(scriptsArray->Get(v8::Integer::New(m_isolate, i))));

+ dispatchDidParseSource(listener, v8::Handle<v8::Object>::Cast(scriptsArray->Get(v8::Integer::New(m_isolate, i))), false);

aandrey 2014/07/07 19:44:32 what is this flag? maybe enums instead?

}

void PageScriptDebugServer::removeListener(ScriptDebugListener* listener, Page* page)