Source/core/inspector/ScriptDebugListener.h - Issue 272613002: DevTools: implemented scriptFailedToParse protocol event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/ScriptDebugListener.h

Issue 272613002: DevTools: implemented scriptFailedToParse protocol event (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/inspector/sources/debugger/script-failed-to-parse.html ('K') | « Source/core/inspector/InspectorDebuggerAgent.cpp ('k') | Source/devtools/Inspector-1.1.json » ('j') | Source/devtools/protocol.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/ScriptDebugListener.h

diff --git a/Source/core/inspector/ScriptDebugListener.h b/Source/core/inspector/ScriptDebugListener.h

index 6153c7c7730d95f62098132ec39378d85c12ec31..7a90dcea6c16cbee14b41d9225eeb15282e6f88e 100644

--- a/Source/core/inspector/ScriptDebugListener.h

+++ b/Source/core/inspector/ScriptDebugListener.h

@@ -71,8 +71,7 @@ public:

virtual ~ScriptDebugListener() { }

- virtual void didParseSource(const String& scriptId, const Script&) = 0;

- virtual void failedToParseSource(const String& url, const String& data, int firstLine, int errorLine, const String& errorMessage) = 0;

+ virtual void didParseSource(const String& scriptId, const Script&, bool hasSyntaxError) = 0;

virtual SkipPauseRequest didPause(ScriptState*, const ScriptValue& callFrames, const ScriptValue& exception, const Vector<String>& hitBreakpoints) = 0;

virtual void didContinue() = 0;

};