Unhide folded sections in wiki pages

Unhide folded sections in wiki pages

On narrow mobile, subheadings are folded by default.
All elements with aria-expanded=false would be unhidden.

Score changes (as of @150259105):

https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-unfold/top-mobile-mhtml.html
  1 entry changed (mobile version of wikipedia):
   Precision remains 1.0
   Recall 0.047 → 0.683
   F1     0.091 → 0.812

No score changes in the following datasets:
  cjk-golden-data
  golden_data_with_knowledge
  distillable-desktop-mhtml
  multi-page-golden-data
  page-links-golden-data
  reader-images-golden-data
  reader-mode-golden-data

BUG=647667
R=mdjones@chromium.org, olivierrobin@chromium.org

Committed: cd538d1b68a9128d704ab9ee92d4e5cbd197abbc

[wychen, 2017-03-03 17:53:29]

Description was changed from

==========
Unhide folded sections in Wikipedia

On narrow mobile, subheadings are folded by default.

BUG=647667
==========

to

==========
Unhide folded sections in Wikipedia pages

On narrow mobile, subheadings are folded by default.

BUG=647667
==========

[Olivier, 2017-03-04 09:26:50]

olivierrobin@chromium.org changed reviewers:
+ olivierrobin@chromium.org

[Olivier, 2017-03-04 09:26:51]

https://codereview.chromium.org/2726123004/diff/1/java/org/chromium/distiller...
File java/org/chromium/distiller/webdocument/DomConverter.java (right):

https://codereview.chromium.org/2726123004/diff/1/java/org/chromium/distiller...
java/org/chromium/distiller/webdocument/DomConverter.java:115: if
(e.getAttribute("aria-expanded").equals("false")) {
Is there a risk that this fix expands all popup menus?

[wychen, 2017-03-14 00:55:36]

Description was changed from

==========
Unhide folded sections in Wikipedia pages

On narrow mobile, subheadings are folded by default.

BUG=647667
==========

to

==========
Unhide folded sections in Wikipedia pages

On narrow mobile, subheadings are folded by default.

No score changes in the following datasets:
  cjk-golden-data
  golden_data_with_knowledge
  distillable-desktop-mhtml
  multi-page-golden-data
  page-links-golden-data
  reader-images-golden-data
  reader-mode-golden-data
  top-mobile-mhtml

BUG=647667
==========

[wychen, 2017-03-14 01:06:01]

wychen@chromium.org changed reviewers:
+ mdjones@chromium.org

[wychen, 2017-03-14 01:06:02]

PTAL

https://codereview.chromium.org/2726123004/diff/1/java/org/chromium/distiller...
File java/org/chromium/distiller/webdocument/DomConverter.java (right):

https://codereview.chromium.org/2726123004/diff/1/java/org/chromium/distiller...
java/org/chromium/distiller/webdocument/DomConverter.java:115: if
(e.getAttribute("aria-expanded").equals("false")) {
On 2017/03/04 09:26:51, Olivier Robin wrote:
> Is there a risk that this fix expands all popup menus?

Could be, but I'd expect menus to be removed down the pipeline.
I've run this through our dataset, and no changes in output.

[mdjones, 2017-03-14 15:54:38]

lgtm

[wychen, 2017-03-15 23:22:24]

Description was changed from

==========
Unhide folded sections in Wikipedia pages

On narrow mobile, subheadings are folded by default.

No score changes in the following datasets:
  cjk-golden-data
  golden_data_with_knowledge
  distillable-desktop-mhtml
  multi-page-golden-data
  page-links-golden-data
  reader-images-golden-data
  reader-mode-golden-data
  top-mobile-mhtml

BUG=647667
==========

to

==========
Unhide folded sections in wiki pages

On narrow mobile, subheadings are folded by default.
All elements with aria-expanded=false would be unhidden.

Score changes (as of @150257299):

https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-unfold/top-mobi...
  1 entry changed (mobile version of wikipedia):
   Recall 0.047 → 0.683
   F1     0.091 → 0.812

No score changes in the following datasets:
  cjk-golden-data
  golden_data_with_knowledge
  distillable-desktop-mhtml
  multi-page-golden-data
  page-links-golden-data
  reader-images-golden-data
  reader-mode-golden-data

BUG=647667
==========

[wychen, 2017-03-15 23:29:51]

Description was changed from

==========
Unhide folded sections in wiki pages

On narrow mobile, subheadings are folded by default.
All elements with aria-expanded=false would be unhidden.

Score changes (as of @150257299):

https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-unfold/top-mobi...
  1 entry changed (mobile version of wikipedia):
   Recall 0.047 → 0.683
   F1     0.091 → 0.812

No score changes in the following datasets:
  cjk-golden-data
  golden_data_with_knowledge
  distillable-desktop-mhtml
  multi-page-golden-data
  page-links-golden-data
  reader-images-golden-data
  reader-mode-golden-data

BUG=647667
==========

to

==========
Unhide folded sections in wiki pages

On narrow mobile, subheadings are folded by default.
All elements with aria-expanded=false would be unhidden.

Score changes (as of @150259105):

https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-unfold/top-mobi...
  1 entry changed (mobile version of wikipedia):
   Recall 0.047 → 0.683
   F1     0.091 → 0.812

No score changes in the following datasets:
  cjk-golden-data
  golden_data_with_knowledge
  distillable-desktop-mhtml
  multi-page-golden-data
  page-links-golden-data
  reader-images-golden-data
  reader-mode-golden-data

BUG=647667
==========

[wychen, 2017-03-15 23:48:08]

Description was changed from

==========
Unhide folded sections in wiki pages

On narrow mobile, subheadings are folded by default.
All elements with aria-expanded=false would be unhidden.

Score changes (as of @150259105):

https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-unfold/top-mobi...
  1 entry changed (mobile version of wikipedia):
   Recall 0.047 → 0.683
   F1     0.091 → 0.812

No score changes in the following datasets:
  cjk-golden-data
  golden_data_with_knowledge
  distillable-desktop-mhtml
  multi-page-golden-data
  page-links-golden-data
  reader-images-golden-data
  reader-mode-golden-data

BUG=647667
==========

to

==========
Unhide folded sections in wiki pages

On narrow mobile, subheadings are folded by default.
All elements with aria-expanded=false would be unhidden.

Score changes (as of @150259105):

https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-unfold/top-mobi...
  1 entry changed (mobile version of wikipedia):
   Precision remains 1.0
   Recall 0.047 → 0.683
   F1     0.091 → 0.812

No score changes in the following datasets:
  cjk-golden-data
  golden_data_with_knowledge
  distillable-desktop-mhtml
  multi-page-golden-data
  page-links-golden-data
  reader-images-golden-data
  reader-mode-golden-data

BUG=647667
==========

[Olivier, 2017-04-10 07:36:39]

lgtm

[wychen, 2017-04-11 00:33:37]

Description was changed from

==========
Unhide folded sections in wiki pages

On narrow mobile, subheadings are folded by default.
All elements with aria-expanded=false would be unhidden.

Score changes (as of @150259105):

https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-unfold/top-mobi...
  1 entry changed (mobile version of wikipedia):
   Precision remains 1.0
   Recall 0.047 → 0.683
   F1     0.091 → 0.812

No score changes in the following datasets:
  cjk-golden-data
  golden_data_with_knowledge
  distillable-desktop-mhtml
  multi-page-golden-data
  page-links-golden-data
  reader-images-golden-data
  reader-mode-golden-data

BUG=647667
==========

to

==========
Unhide folded sections in wiki pages

On narrow mobile, subheadings are folded by default.
All elements with aria-expanded=false would be unhidden.

Score changes (as of @150259105):

https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-unfold/top-mobi...
  1 entry changed (mobile version of wikipedia):
   Precision remains 1.0
   Recall 0.047 → 0.683
   F1     0.091 → 0.812

No score changes in the following datasets:
  cjk-golden-data
  golden_data_with_knowledge
  distillable-desktop-mhtml
  multi-page-golden-data
  page-links-golden-data
  reader-images-golden-data
  reader-mode-golden-data

BUG=647667
R=mdjones@chromium.org, olivierrobin@chromium.org

Committed: cd538d1b68a9128d704ab9ee92d4e5cbd197abbc
==========

[wychen, 2017-04-11 00:33:37]

Committed patchset #1 (id:1) manually as
cd538d1b68a9128d704ab9ee92d4e5cbd197abbc (presubmit successful).