Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: third_party/WebKit/Source/bindings/scripts/idl_compiler.py

Issue 2726103005: bindings: Generate all interfaces in a single action on mac (Closed)
Patch Set: Use a single action for mac Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/idl_compiler.py
diff --git a/third_party/WebKit/Source/bindings/scripts/idl_compiler.py b/third_party/WebKit/Source/bindings/scripts/idl_compiler.py
index 444415c1d9c5bdb47b46633bccaa6439302b5cea..7c9728d29f34a190efa14018070d368c3e0b4492 100755
--- a/third_party/WebKit/Source/bindings/scripts/idl_compiler.py
+++ b/third_party/WebKit/Source/bindings/scripts/idl_compiler.py
@@ -55,6 +55,8 @@ def parse_options():
help='cache directory, defaults to output directory')
parser.add_option('--generate-impl',
action="store_true", default=False)
+ parser.add_option('--read-idl-list-from-file',
peria 2017/03/03 07:45:07 (optional) '....-list' is consistent with other ge
bashi 2017/03/03 07:59:13 Yeah, but I thought it's a bit redundant.
+ action="store_true", default=False)
parser.add_option('--output-directory')
parser.add_option('--impl-output-directory')
parser.add_option('--info-dir')
@@ -181,14 +183,18 @@ def main():
options, input_filename = parse_options()
info_provider = create_component_info_provider(
options.info_dir, options.target_component)
- if options.generate_impl:
- if not info_provider.interfaces_info:
- raise Exception('Interfaces info is required to generate '
- 'union types containers')
+ if options.generate_impl or options.read_idl_list_from_file:
# |input_filename| should be a file which contains a list of IDL
# dictionary paths.
input_filenames = read_idl_files_list_from_file(input_filename,
is_gyp_format=True)
+ else:
+ input_filenames = [input_filename]
+
+ if options.generate_impl:
+ if not info_provider.interfaces_info:
+ raise Exception('Interfaces info is required to generate '
+ 'impl classes')
generate_dictionary_impl(CodeGeneratorDictionaryImpl, info_provider,
options, input_filenames)
generate_union_type_containers(CodeGeneratorUnionType, info_provider,
@@ -196,9 +202,8 @@ def main():
generate_callback_function_impl(CodeGeneratorCallbackFunction,
info_provider, options)
else:
- # |input_filename| should be a path of an IDL file.
generate_bindings(CodeGeneratorV8, info_provider, options,
- [input_filename])
+ input_filenames)
if __name__ == '__main__':

Powered by Google App Engine
This is Rietveld 408576698